|
Description
Nick Clemens (kidclamp)
2022-04-21 11:16:30 UTC
Created attachment 133539 [details] [review] Bug 30577: Move item specific pickup locations to the left When placing holds, staff will set the pickup location at the top, choose an item, then place the hold. It is easy not to notice the item specific locations dropdown. This patch moves it in line with the other selction areas on the request screen. To test: 1 - Find a record on staff client, place hold 2 - Select a patron to load the request screen 3 - Note the location dropdown for next available hold 4 - Note the item specific locations on the far right 5 - Apply patch 6 - Reload the page 7 - Note the item specific location dropdowns are now moved to the left 8 - Place the hold, verify it works with the dropdowns 9 - Verify title levelholds still work as expected 10 - Verify multi-holds still work Created attachment 133540 [details] [review] Bug 30577: Fix a missing closing tag This didn't affect table display, but when there was a biblioloo.warn we were not closing the first <td> tag Confirm multi-holds table loads correctly when one (or more) records cannot be held Created attachment 133572 [details] [review] Bug 30577: Move item specific pickup locations to the left When placing holds, staff will set the pickup location at the top, choose an item, then place the hold. It is easy not to notice the item specific locations dropdown. This patch moves it in line with the other selction areas on the request screen. To test: 1 - Find a record on staff client, place hold 2 - Select a patron to load the request screen 3 - Note the location dropdown for next available hold 4 - Note the item specific locations on the far right 5 - Apply patch 6 - Reload the page 7 - Note the item specific location dropdowns are now moved to the left 8 - Place the hold, verify it works with the dropdowns 9 - Verify title levelholds still work as expected 10 - Verify multi-holds still work Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Created attachment 133573 [details] [review] Bug 30577: Fix a missing closing tag This didn't affect table display, but when there was a biblioloo.warn we were not closing the first <td> tag Confirm multi-holds table loads correctly when one (or more) records cannot be held Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Created attachment 133687 [details] [review] Bug 30577: Move item specific pickup locations to the left When placing holds, staff will set the pickup location at the top, choose an item, then place the hold. It is easy not to notice the item specific locations dropdown. This patch moves it in line with the other selction areas on the request screen. To test: 1 - Find a record on staff client, place hold 2 - Select a patron to load the request screen 3 - Note the location dropdown for next available hold 4 - Note the item specific locations on the far right 5 - Apply patch 6 - Reload the page 7 - Note the item specific location dropdowns are now moved to the left 8 - Place the hold, verify it works with the dropdowns 9 - Verify title levelholds still work as expected 10 - Verify multi-holds still work Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Created attachment 133688 [details] [review] Bug 30577: Fix a missing closing tag This didn't affect table display, but when there was a biblioloo.warn we were not closing the first <td> tag Confirm multi-holds table loads correctly when one (or more) records cannot be held Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> A change to ysearch.pl crept in here Nick.. I'll fix it up for you whilst QAing Created attachment 133896 [details] [review] Bug 30577: Move item specific pickup locations to the left When placing holds, staff will set the pickup location at the top, choose an item, then place the hold. It is easy not to notice the item specific locations dropdown. This patch moves it in line with the other selction areas on the request screen. To test: 1 - Find a record on staff client, place hold 2 - Select a patron to load the request screen 3 - Note the location dropdown for next available hold 4 - Note the item specific locations on the far right 5 - Apply patch 6 - Reload the page 7 - Note the item specific location dropdowns are now moved to the left 8 - Place the hold, verify it works with the dropdowns 9 - Verify title levelholds still work as expected 10 - Verify multi-holds still work Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 133897 [details] [review] Bug 30577: Fix a missing closing tag This didn't affect table display, but when there was a biblioloo.warn we were not closing the first <td> tag Confirm multi-holds table loads correctly when one (or more) records cannot be held Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Looks good, works as expceted.. QA scripts happy. PQA Why is there even an item specific location selector? Do we not always place exactly one hold and the pickup location is specific to the hold, regardless of whether it is an item hold or biblio hold? (In reply to Andreas Jonsson from comment #11) > Why is there even an item specific location selector? > > Do we not always place exactly one hold and the pickup location is specific > to the hold, regardless of whether it is an item hold or biblio hold? I think not the number of holds is the issue here, but the valid pickup locations. The pull down for 'next available' can take into account what the sum of items allows for pickup-location, but for each item there might be differences depending on where it's coming from. (In reply to Andreas Jonsson from comment #11) > Why is there even an item specific location selector? > > Do we not always place exactly one hold and the pickup location is specific > to the hold, regardless of whether it is an item hold or biblio hold? The item-specific pickup location dropdowns were added in Bug 28338. As Katrin says, these don't impact how many holds one is placing. They allow Koha to correctly provide only valid pickup locations in a situation where specific items are limited in where they can be transferred for a hold. Wouldn't it be better to disable the radio button and grey out the items that cannot be picked when you select a specific pickup location, and conversely, grey out and disable pickup locations in the drop down menu when selecting an item? (In reply to Andreas Jonsson from comment #14) > Wouldn't it be better to disable the radio button and grey out the items > that cannot be picked when you select a specific pickup location, and > conversely, grey out and disable pickup locations in the drop down menu when > selecting an item? That adjustment is taking place on bug 30579 This bug is simply addressing the fact that all other selections are made on the left hand side of the screen - having the pickup location on the far right means it is not obvious when selecting an item Makes sens. In addition, we may replace column name "Allowed pickup locations" with something like "Choose pickup locations". Pushed to master for 22.05, thanks to everybody involved [U+1F984] Created attachment 135017 [details] [review] Bug 30577: [21.11.x] Move item specific pickup locations to the left When placing holds, staff will set the pickup location at the top, choose an item, then place the hold. It is easy not to notice the item specific locations dropdown. This patch moves it in line with the other selction areas on the request screen. To test: 1 - Find a record on staff client, place hold 2 - Select a patron to load the request screen 3 - Note the location dropdown for next available hold 4 - Note the item specific locations on the far right 5 - Apply patch 6 - Reload the page 7 - Note the item specific location dropdowns are now moved to the left 8 - Place the hold, verify it works with the dropdowns 9 - Verify title levelholds still work as expected 10 - Verify multi-holds still work Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Bug 30577: Fix a missing closing tag This didn't affect table display, but when there was a biblioloo.warn we were not closing the first <td> tag Confirm multi-holds table loads correctly when one (or more) records cannot be held Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> |