Bug 30577 - Item specific holds location can be missed when placing title level holds
Summary: Item specific holds location can be missed when placing title level holds
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Nick Clemens
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 30579
  Show dependency treegraph
 
Reported: 2022-04-21 11:16 UTC by Nick Clemens
Modified: 2023-12-28 20:42 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.05.00


Attachments
Bug 30577: Move item specific pickup locations to the left (10.03 KB, patch)
2022-04-21 11:18 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 30577: Fix a missing closing tag (1.74 KB, patch)
2022-04-21 11:18 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 30577: Move item specific pickup locations to the left (10.10 KB, patch)
2022-04-21 15:00 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 30577: Fix a missing closing tag (1.81 KB, patch)
2022-04-21 15:00 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 30577: Move item specific pickup locations to the left (10.15 KB, patch)
2022-04-22 15:01 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 30577: Fix a missing closing tag (1.86 KB, patch)
2022-04-22 15:01 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 30577: Move item specific pickup locations to the left (9.73 KB, patch)
2022-04-26 13:32 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 30577: Fix a missing closing tag (1.86 KB, patch)
2022-04-26 13:32 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 30577: [21.11.x] Move item specific pickup locations to the left (10.62 KB, patch)
2022-05-16 11:21 UTC, Nick Clemens
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2022-04-21 11:16:30 UTC

    
Comment 1 Nick Clemens 2022-04-21 11:18:35 UTC
Created attachment 133539 [details] [review]
Bug 30577: Move item specific pickup locations to the left

When placing holds, staff will set the pickup location at the top,
choose an item, then place the hold.
It is easy not to notice the item specific locations dropdown.

This patch moves it in line with the other selction areas on the request screen.

To test:
 1 - Find a record on staff client, place hold
 2 - Select a patron to load the request screen
 3 - Note the location dropdown for next available hold
 4 - Note the item specific locations on the far right
 5 - Apply patch
 6 - Reload the page
 7 - Note the item specific location dropdowns are now moved to the left
 8 - Place the hold, verify it works with the dropdowns
 9 - Verify title levelholds still work as expected
10 - Verify multi-holds still work
Comment 2 Nick Clemens 2022-04-21 11:18:38 UTC
Created attachment 133540 [details] [review]
Bug 30577: Fix a missing closing tag

This didn't affect table display, but when there was a biblioloo.warn
we were not closing the first <td> tag

Confirm multi-holds table loads correctly when one (or more) records cannot be held
Comment 3 Andrew Fuerste-Henry 2022-04-21 15:00:26 UTC
Created attachment 133572 [details] [review]
Bug 30577: Move item specific pickup locations to the left

When placing holds, staff will set the pickup location at the top,
choose an item, then place the hold.
It is easy not to notice the item specific locations dropdown.

This patch moves it in line with the other selction areas on the request screen.

To test:
 1 - Find a record on staff client, place hold
 2 - Select a patron to load the request screen
 3 - Note the location dropdown for next available hold
 4 - Note the item specific locations on the far right
 5 - Apply patch
 6 - Reload the page
 7 - Note the item specific location dropdowns are now moved to the left
 8 - Place the hold, verify it works with the dropdowns
 9 - Verify title levelholds still work as expected
10 - Verify multi-holds still work

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 4 Andrew Fuerste-Henry 2022-04-21 15:00:31 UTC
Created attachment 133573 [details] [review]
Bug 30577: Fix a missing closing tag

This didn't affect table display, but when there was a biblioloo.warn
we were not closing the first <td> tag

Confirm multi-holds table loads correctly when one (or more) records cannot be held

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 5 Andrew Fuerste-Henry 2022-04-22 15:01:45 UTC
Created attachment 133687 [details] [review]
Bug 30577: Move item specific pickup locations to the left

When placing holds, staff will set the pickup location at the top,
choose an item, then place the hold.
It is easy not to notice the item specific locations dropdown.

This patch moves it in line with the other selction areas on the request screen.

To test:
 1 - Find a record on staff client, place hold
 2 - Select a patron to load the request screen
 3 - Note the location dropdown for next available hold
 4 - Note the item specific locations on the far right
 5 - Apply patch
 6 - Reload the page
 7 - Note the item specific location dropdowns are now moved to the left
 8 - Place the hold, verify it works with the dropdowns
 9 - Verify title levelholds still work as expected
10 - Verify multi-holds still work

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us>
Comment 6 Andrew Fuerste-Henry 2022-04-22 15:01:49 UTC
Created attachment 133688 [details] [review]
Bug 30577: Fix a missing closing tag

This didn't affect table display, but when there was a biblioloo.warn
we were not closing the first <td> tag

Confirm multi-holds table loads correctly when one (or more) records cannot be held

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us>
Comment 7 Martin Renvoize 2022-04-26 13:29:44 UTC
A change to ysearch.pl crept in here Nick.. I'll fix it up for you whilst QAing
Comment 8 Martin Renvoize 2022-04-26 13:32:15 UTC
Created attachment 133896 [details] [review]
Bug 30577: Move item specific pickup locations to the left

When placing holds, staff will set the pickup location at the top,
choose an item, then place the hold.
It is easy not to notice the item specific locations dropdown.

This patch moves it in line with the other selction areas on the request screen.

To test:
 1 - Find a record on staff client, place hold
 2 - Select a patron to load the request screen
 3 - Note the location dropdown for next available hold
 4 - Note the item specific locations on the far right
 5 - Apply patch
 6 - Reload the page
 7 - Note the item specific location dropdowns are now moved to the left
 8 - Place the hold, verify it works with the dropdowns
 9 - Verify title levelholds still work as expected
10 - Verify multi-holds still work

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 9 Martin Renvoize 2022-04-26 13:32:20 UTC
Created attachment 133897 [details] [review]
Bug 30577: Fix a missing closing tag

This didn't affect table display, but when there was a biblioloo.warn
we were not closing the first <td> tag

Confirm multi-holds table loads correctly when one (or more) records cannot be held

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us>
Comment 10 Martin Renvoize 2022-04-26 13:32:46 UTC
Looks good, works as expceted.. QA scripts happy.

PQA
Comment 11 Andreas Jonsson 2022-05-02 07:25:53 UTC
Why is there even an item specific location selector?

Do we not always place exactly one hold and the pickup location is specific to the hold, regardless of whether it is an item hold or biblio hold?
Comment 12 Katrin Fischer 2022-05-02 09:51:03 UTC
(In reply to Andreas Jonsson from comment #11)
> Why is there even an item specific location selector?
> 
> Do we not always place exactly one hold and the pickup location is specific
> to the hold, regardless of whether it is an item hold or biblio hold?

I think not the number of holds is the issue here, but the valid pickup locations. The pull down for 'next available' can take into account what the sum of items allows for pickup-location, but for each item there might be differences depending on where it's coming from.
Comment 13 Andrew Fuerste-Henry 2022-05-02 12:41:53 UTC
(In reply to Andreas Jonsson from comment #11)
> Why is there even an item specific location selector?
> 
> Do we not always place exactly one hold and the pickup location is specific
> to the hold, regardless of whether it is an item hold or biblio hold?

The item-specific pickup location dropdowns were added in Bug 28338. As Katrin says, these don't impact how many holds one is placing. They allow Koha to correctly provide only valid pickup locations in a situation where specific items are limited in where they can be transferred for a hold.
Comment 14 Andreas Jonsson 2022-05-02 13:03:27 UTC
Wouldn't it be better to disable the radio button and grey out the items that cannot be picked when you select a specific pickup location, and conversely, grey out and disable pickup locations in the drop down menu when selecting an item?
Comment 15 Nick Clemens 2022-05-03 12:49:06 UTC
(In reply to Andreas Jonsson from comment #14)
> Wouldn't it be better to disable the radio button and grey out the items
> that cannot be picked when you select a specific pickup location, and
> conversely, grey out and disable pickup locations in the drop down menu when
> selecting an item?

That adjustment is taking place on bug 30579

This bug is simply addressing the fact that all other selections are made on the left hand side of the screen - having the pickup location on the far right means it is not obvious when selecting an item
Comment 16 Fridolin Somers 2022-05-04 20:53:39 UTC
Makes sens.

In addition, we may replace column name "Allowed pickup locations" with something like "Choose pickup locations".
Comment 17 Fridolin Somers 2022-05-05 00:33:07 UTC
Pushed to master for 22.05, thanks to everybody involved 🦄
Comment 18 Nick Clemens 2022-05-16 11:21:29 UTC
Created attachment 135017 [details] [review]
Bug 30577: [21.11.x] Move item specific pickup locations to the left

When placing holds, staff will set the pickup location at the top,
choose an item, then place the hold.
It is easy not to notice the item specific locations dropdown.

This patch moves it in line with the other selction areas on the request screen.

To test:
 1 - Find a record on staff client, place hold
 2 - Select a patron to load the request screen
 3 - Note the location dropdown for next available hold
 4 - Note the item specific locations on the far right
 5 - Apply patch
 6 - Reload the page
 7 - Note the item specific location dropdowns are now moved to the left
 8 - Place the hold, verify it works with the dropdowns
 9 - Verify title levelholds still work as expected
10 - Verify multi-holds still work

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Bug 30577: Fix a missing closing tag

This didn't affect table display, but when there was a biblioloo.warn
we were not closing the first <td> tag

Confirm multi-holds table loads correctly when one (or more) records cannot be held

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us>