Summary: | Cannot add field mappings to Elasticsearch configuration | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Searching - Elasticsearch | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | critical | ||
Priority: | P5 - low | CC: | andrew, jonathan.druart, kyle, victor |
Version: | Main | Keywords: | rel_21_11_candidate |
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34695 | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.05.00,21.11.05
|
|
Circulation function: | |||
Bug Depends on: | 29893 | ||
Bug Blocks: | |||
Attachments: |
Bug 30584: Fix ES mapping creation
Bug 30584: Fix ES mapping creation Bug 30584: Fix ES mapping creation |
Description
Nick Clemens (kidclamp)
2022-04-21 15:01:27 UTC
This template is a nightmare... Created attachment 133595 [details] [review] Bug 30584: Fix ES mapping creation We need to tell DT that we are adding/removing row, not only deal manually with the DOM. This patch also fixes the following bug: if you add or remove a row from the "biblio" tab, then go to another tab and back to "biblio", all changes were gone (bug existed prior to bug 29893). Test plan: Add, edit and remove mappings, switch from tabs and save. Use the filters, save (29893 regression test) Upping severity, it impacts stable. Created attachment 133657 [details] [review] Bug 30584: Fix ES mapping creation We need to tell DT that we are adding/removing row, not only deal manually with the DOM. This patch also fixes the following bug: if you add or remove a row from the "biblio" tab, then go to another tab and back to "biblio", all changes were gone (bug existed prior to bug 29893). Test plan: Add, edit and remove mappings, switch from tabs and save. Use the filters, save (29893 regression test) Signed-off-by: David Nind <david@davidnind.com> Holding of on release of 21.11.05 until this has been pushed to master so I can backport it. Created attachment 133800 [details] [review] Bug 30584: Fix ES mapping creation We need to tell DT that we are adding/removing row, not only deal manually with the DOM. This patch also fixes the following bug: if you add or remove a row from the "biblio" tab, then go to another tab and back to "biblio", all changes were gone (bug existed prior to bug 29893). Test plan: Add, edit and remove mappings, switch from tabs and save. Use the filters, save (29893 regression test) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 22.05, thanks to everybody involved [U+1F984] Pushed to 21.11.x for 21.11.05 Missing dependency, not backported to 21.05 |