bug 29893 redraws the table before submission - this appears to remove any rows we have added To test: 1 - Browse to Administration -> Catalog -> Search engine configuration (Elasticsearch) 2 - Click on 'Bibliographic records' tab 3 - Scroll to bottom and enter a new mapping and click '+Add' button at far right 4 - Click 'Save' button at bottom 5 - You may notice your new row disappears, then the page reloads 6 - Check for your new mapping - it has not been added
This template is a nightmare...
Created attachment 133595 [details] [review] Bug 30584: Fix ES mapping creation We need to tell DT that we are adding/removing row, not only deal manually with the DOM. This patch also fixes the following bug: if you add or remove a row from the "biblio" tab, then go to another tab and back to "biblio", all changes were gone (bug existed prior to bug 29893). Test plan: Add, edit and remove mappings, switch from tabs and save. Use the filters, save (29893 regression test)
Upping severity, it impacts stable.
Created attachment 133657 [details] [review] Bug 30584: Fix ES mapping creation We need to tell DT that we are adding/removing row, not only deal manually with the DOM. This patch also fixes the following bug: if you add or remove a row from the "biblio" tab, then go to another tab and back to "biblio", all changes were gone (bug existed prior to bug 29893). Test plan: Add, edit and remove mappings, switch from tabs and save. Use the filters, save (29893 regression test) Signed-off-by: David Nind <david@davidnind.com>
Holding of on release of 21.11.05 until this has been pushed to master so I can backport it.
Created attachment 133800 [details] [review] Bug 30584: Fix ES mapping creation We need to tell DT that we are adding/removing row, not only deal manually with the DOM. This patch also fixes the following bug: if you add or remove a row from the "biblio" tab, then go to another tab and back to "biblio", all changes were gone (bug existed prior to bug 29893). Test plan: Add, edit and remove mappings, switch from tabs and save. Use the filters, save (29893 regression test) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 22.05, thanks to everybody involved [U+1F984]
Pushed to 21.11.x for 21.11.05
Missing dependency, not backported to 21.05