Bug 30598

Summary: Replacement cost is not copied from retail price when ordering from file
Product: Koha Reporter: Caroline Cyr La Rose <caroline.cyr-la-rose>
Component: AcquisitionsAssignee: Phan Tung Bui <phan-tung.bui>
Status: Pushed to oldstable --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: caroline.cyr-la-rose, chughesman, fridolin.somers, koha, lucas, matt.blenkinsop, nick, phan-tung.bui, philippe.blouin
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.06,23.05.12
Attachments: Bug30598: Replacement cost is not copied from retail price when ordering from file
Bug30598: remove all the console.log redundancies
Bug30598: Replacement cost is not copied from retail price when ordering from file
Bug30598: remove all the console.log redundancies
Bug 30598: Replacement cost is not copied from retail price when ordering from file
Bug 30598: remove all the console.log redundancies
Bug 30598: Replacement cost is not copied from retail price when ordering from file
Bug 30598: remove all the console.log redundancies

Description Caroline Cyr La Rose 2022-04-22 18:39:49 UTC
In acquisitions, when you order an individual title, and you enter the "vendor price", it is copied in the retail price, the replacement cost, and the budgeted cost. However, if you order from a file, when you enter the price, the replacement price field stays empty.

To test :
1- In Acquisitions, create a basket
2- Add an order from a new (empty) record 
 --> Note that when you enter the "vendor price", it is copied in the "replacement cost" field
3- Add an order from a new file
 --> Note that when you enter the "price", the "replacement price" field stays empty

This means you have to enter the price twice for each item ordered.
Comment 1 Carolyn Hughesman 2022-08-12 12:32:19 UTC
We have come across this as well and are very interested in a fix for this.
Comment 2 Phan Tung Bui 2024-04-12 20:59:48 UTC
Created attachment 164865 [details] [review]
Bug30598: Replacement cost is not copied from retail price when ordering from file

Test plan :
To test :
1- In Acquisitions, create a basket
2- Add an order from a new (empty) record
 --> Note that when you enter the "vendor price", it is copied in the "replacement cost" field
3- Add an order from a new file
 --> Note that when you enter the "price", the "replacement price" field stays empty
4- Apply the batch
5- Redo step 3 and notice that when you change the 'price', the
'replacement price' syncs with it
Comment 3 Matt Blenkinsop 2024-04-18 09:56:09 UTC
Hi, there are couple of 'console.log()' lines in the patch that need removing - can you remove these and then I'll look at testing this for you :)
Comment 4 Phan Tung Bui 2024-04-18 13:58:31 UTC
Created attachment 165107 [details] [review]
Bug30598: remove all the console.log redundancies

Please test the patch. Thank you!
Comment 5 Matt Blenkinsop 2024-04-18 14:13:01 UTC
Created attachment 165109 [details] [review]
Bug30598: Replacement cost is not copied from retail price when ordering from file

Test plan :
To test :
1- In Acquisitions, create a basket
2- Add an order from a new (empty) record
 --> Note that when you enter the "vendor price", it is copied in the "replacement cost" field
3- Add an order from a new file
 --> Note that when you enter the "price", the "replacement price" field stays empty
4- Apply the batch
5- Redo step 3 and notice that when you change the 'price', the
'replacement price' syncs with it

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 6 Matt Blenkinsop 2024-04-18 14:13:03 UTC
Created attachment 165110 [details] [review]
Bug30598: remove all the console.log redundancies

Please test the patch. Thank you!

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 7 Lucas Gass 2024-04-22 17:13:34 UTC
This is working fine, code looks good. Just fix your commit messages please! 

	* Commit title does not start with 'Bug XXXXX: ' - 8c0e31674b
	* Commit title does not start with 'Bug XXXXX: ' - 21e58343d1
Comment 8 Phan Tung Bui 2024-04-22 19:42:47 UTC
Created attachment 165348 [details] [review]
Bug 30598: Replacement cost is not copied from retail price when ordering from file

Test plan :
To test :
1- In Acquisitions, create a basket
2- Add an order from a new (empty) record
 --> Note that when you enter the "vendor price", it is copied in the "replacement cost" field
3- Add an order from a new file
 --> Note that when you enter the "price", the "replacement price" field stays empty
4- Apply the batch
5- Redo step 3 and notice that when you change the 'price', the
'replacement price' syncs with it

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 9 Phan Tung Bui 2024-04-22 19:44:39 UTC
Created attachment 165349 [details] [review]
Bug 30598: remove all the console.log redundancies

Please test the patch. Thank you!

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 10 Lucas Gass 2024-04-22 22:55:04 UTC
Created attachment 165350 [details] [review]
Bug 30598: Replacement cost is not copied from retail price when ordering from file

Test plan :
To test :
1- In Acquisitions, create a basket
2- Add an order from a new (empty) record
 --> Note that when you enter the "vendor price", it is copied in the "replacement cost" field
3- Add an order from a new file
 --> Note that when you enter the "price", the "replacement price" field stays empty
4- Apply the batch
5- Redo step 3 and notice that when you change the 'price', the
'replacement price' syncs with it

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 11 Lucas Gass 2024-04-22 22:55:06 UTC
Created attachment 165351 [details] [review]
Bug 30598: remove all the console.log redundancies

Please test the patch. Thank you!

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 12 Katrin Fischer 2024-04-29 07:24:26 UTC
Should this be a bug instead of an enh?
Comment 13 Katrin Fischer 2024-04-29 07:37:50 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 14 Fridolin Somers 2024-05-24 09:56:05 UTC
Pushed to 23.11.x for 23.11.06
Comment 15 Lucas Gass 2024-05-28 21:06:47 UTC
Backported to 23.05.x for upcoming 23.05.12