In acquisitions, when you order an individual title, and you enter the "vendor price", it is copied in the retail price, the replacement cost, and the budgeted cost. However, if you order from a file, when you enter the price, the replacement price field stays empty. To test : 1- In Acquisitions, create a basket 2- Add an order from a new (empty) record --> Note that when you enter the "vendor price", it is copied in the "replacement cost" field 3- Add an order from a new file --> Note that when you enter the "price", the "replacement price" field stays empty This means you have to enter the price twice for each item ordered.
We have come across this as well and are very interested in a fix for this.
Created attachment 164865 [details] [review] Bug30598: Replacement cost is not copied from retail price when ordering from file Test plan : To test : 1- In Acquisitions, create a basket 2- Add an order from a new (empty) record --> Note that when you enter the "vendor price", it is copied in the "replacement cost" field 3- Add an order from a new file --> Note that when you enter the "price", the "replacement price" field stays empty 4- Apply the batch 5- Redo step 3 and notice that when you change the 'price', the 'replacement price' syncs with it
Hi, there are couple of 'console.log()' lines in the patch that need removing - can you remove these and then I'll look at testing this for you :)
Created attachment 165107 [details] [review] Bug30598: remove all the console.log redundancies Please test the patch. Thank you!
Created attachment 165109 [details] [review] Bug30598: Replacement cost is not copied from retail price when ordering from file Test plan : To test : 1- In Acquisitions, create a basket 2- Add an order from a new (empty) record --> Note that when you enter the "vendor price", it is copied in the "replacement cost" field 3- Add an order from a new file --> Note that when you enter the "price", the "replacement price" field stays empty 4- Apply the batch 5- Redo step 3 and notice that when you change the 'price', the 'replacement price' syncs with it Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Created attachment 165110 [details] [review] Bug30598: remove all the console.log redundancies Please test the patch. Thank you! Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
This is working fine, code looks good. Just fix your commit messages please! * Commit title does not start with 'Bug XXXXX: ' - 8c0e31674b * Commit title does not start with 'Bug XXXXX: ' - 21e58343d1
Created attachment 165348 [details] [review] Bug 30598: Replacement cost is not copied from retail price when ordering from file Test plan : To test : 1- In Acquisitions, create a basket 2- Add an order from a new (empty) record --> Note that when you enter the "vendor price", it is copied in the "replacement cost" field 3- Add an order from a new file --> Note that when you enter the "price", the "replacement price" field stays empty 4- Apply the batch 5- Redo step 3 and notice that when you change the 'price', the 'replacement price' syncs with it Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Created attachment 165349 [details] [review] Bug 30598: remove all the console.log redundancies Please test the patch. Thank you! Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Created attachment 165350 [details] [review] Bug 30598: Replacement cost is not copied from retail price when ordering from file Test plan : To test : 1- In Acquisitions, create a basket 2- Add an order from a new (empty) record --> Note that when you enter the "vendor price", it is copied in the "replacement cost" field 3- Add an order from a new file --> Note that when you enter the "price", the "replacement price" field stays empty 4- Apply the batch 5- Redo step 3 and notice that when you change the 'price', the 'replacement price' syncs with it Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 165351 [details] [review] Bug 30598: remove all the console.log redundancies Please test the patch. Thank you! Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Should this be a bug instead of an enh?
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.06
Backported to 23.05.x for upcoming 23.05.12