| Summary: | Reindent serial claims template | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | arthur.suzuki, david, lucas |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This enhancement updates the serial claims template in the staff interface (claims.tt) so that the indentation is consistent and replaces tabs with spaces. It also adds comments to highlight the markup structure.
|
Version(s) released in: |
22.11.00, 22.05.04
|
| Circulation function: | |||
| Attachments: |
Bug 30609: Reindent serial claims template
Bug 30609: (follow-up) Add markup comments Bug 30609: Reindent serial claims template Bug 30609: (follow-up) Add markup comments Screenshots - minor layout differences Bug 30609: Reindent serial claims template Bug 30609: (follow-up) Add markup comments |
||
|
Description
Owen Leonard
2022-04-25 14:09:00 UTC
Created attachment 134261 [details] [review] Bug 30609: Reindent serial claims template This patch updates the serial claims template so that the indentation is consistent. Tabs are replaced with spaces. To test you must have at least one subscription with late issues. - Apply the patch and go to Serials -> Claims and select the vendor responsible for your late issue. - On the "Missing issues" page, confirm that everything looks correct. - All functionality should be the same: Filters, table sorting, CSV export, and claim notification. Created attachment 134262 [details] [review] Bug 30609: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Created attachment 135013 [details] [review] Bug 30609: Reindent serial claims template This patch updates the serial claims template so that the indentation is consistent. Tabs are replaced with spaces. To test you must have at least one subscription with late issues. - Apply the patch and go to Serials -> Claims and select the vendor responsible for your late issue. - On the "Missing issues" page, confirm that everything looks correct. - All functionality should be the same: Filters, table sorting, CSV export, and claim notification. Signed-off-by: David Nind <david@davidnind.com> Created attachment 135014 [details] [review] Bug 30609: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: David Nind <david@davidnind.com> Created attachment 135015 [details]
Screenshots - minor layout differences
Everything seems to work as expected after applying the patches.
I did notice one minor layout difference, which I'm not sure whether it needs fixing. See the attachment for screenshots. There is extra space below the table between 'Select CSV profile..." and "Select notice...". The paragraphs are now aligned, which is good.
Created attachment 135116 [details] [review] Bug 30609: Reindent serial claims template This patch updates the serial claims template so that the indentation is consistent. Tabs are replaced with spaces. To test you must have at least one subscription with late issues. - Apply the patch and go to Serials -> Claims and select the vendor responsible for your late issue. - On the "Missing issues" page, confirm that everything looks correct. - All functionality should be the same: Filters, table sorting, CSV export, and claim notification. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 135118 [details] [review] Bug 30609: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 22.11. Nice work everyone, thanks! Backported to 22.05.x for 22.05.04 conflicts when trying to apply to 21.11.x. please provide backport if needed. |