Bug 30609 - Reindent serial claims template
Summary: Reindent serial claims template
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-25 14:09 UTC by Owen Leonard
Modified: 2023-06-08 22:26 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This enhancement updates the serial claims template in the staff interface (claims.tt) so that the indentation is consistent and replaces tabs with spaces. It also adds comments to highlight the markup structure.
Version(s) released in:
22.11.00, 22.05.04


Attachments
Bug 30609: Reindent serial claims template (27.33 KB, patch)
2022-04-28 13:41 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 30609: (follow-up) Add markup comments (2.32 KB, patch)
2022-04-28 13:41 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 30609: Reindent serial claims template (27.37 KB, patch)
2022-05-16 00:51 UTC, David Nind
Details | Diff | Splinter Review
Bug 30609: (follow-up) Add markup comments (2.37 KB, patch)
2022-05-16 00:51 UTC, David Nind
Details | Diff | Splinter Review
Screenshots - minor layout differences (80.26 KB, application/pdf)
2022-05-16 00:56 UTC, David Nind
Details
Bug 30609: Reindent serial claims template (27.45 KB, patch)
2022-05-18 14:05 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 30609: (follow-up) Add markup comments (2.45 KB, patch)
2022-05-18 14:05 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2022-04-25 14:09:00 UTC
I propose to reformat the serial claims template in the staff interface (claims.tt) so that it has consistent spacing and indentation.
Comment 1 Owen Leonard 2022-04-28 13:41:21 UTC
Created attachment 134261 [details] [review]
Bug 30609: Reindent serial claims template

This patch updates the serial claims template so that the indentation
is consistent. Tabs are replaced with spaces.

To test you must have at least one subscription with late issues.

- Apply the patch and go to Serials -> Claims and select the vendor
  responsible for your late issue.
- On the "Missing issues" page, confirm that everything looks correct.
- All functionality should be the same: Filters, table sorting, CSV
  export, and claim notification.
Comment 2 Owen Leonard 2022-04-28 13:41:26 UTC
Created attachment 134262 [details] [review]
Bug 30609: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.
Comment 3 David Nind 2022-05-16 00:51:53 UTC
Created attachment 135013 [details] [review]
Bug 30609: Reindent serial claims template

This patch updates the serial claims template so that the indentation
is consistent. Tabs are replaced with spaces.

To test you must have at least one subscription with late issues.

- Apply the patch and go to Serials -> Claims and select the vendor
  responsible for your late issue.
- On the "Missing issues" page, confirm that everything looks correct.
- All functionality should be the same: Filters, table sorting, CSV
  export, and claim notification.

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2022-05-16 00:51:58 UTC
Created attachment 135014 [details] [review]
Bug 30609: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 David Nind 2022-05-16 00:56:14 UTC
Created attachment 135015 [details]
Screenshots - minor layout differences

Everything seems to work as expected after applying the patches.

I did notice one minor layout difference, which I'm not sure whether it needs fixing. See the attachment for screenshots. There is extra space below the table between 'Select CSV profile..." and "Select notice...". The paragraphs are now aligned, which is good.
Comment 6 Jonathan Druart 2022-05-18 14:05:18 UTC
Created attachment 135116 [details] [review]
Bug 30609: Reindent serial claims template

This patch updates the serial claims template so that the indentation
is consistent. Tabs are replaced with spaces.

To test you must have at least one subscription with late issues.

- Apply the patch and go to Serials -> Claims and select the vendor
  responsible for your late issue.
- On the "Missing issues" page, confirm that everything looks correct.
- All functionality should be the same: Filters, table sorting, CSV
  export, and claim notification.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 7 Jonathan Druart 2022-05-18 14:05:23 UTC
Created attachment 135118 [details] [review]
Bug 30609: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 8 Tomás Cohen Arazi 2022-06-25 14:18:09 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 9 Lucas Gass 2022-07-29 16:13:59 UTC
Backported to 22.05.x for 22.05.04
Comment 10 Arthur Suzuki 2022-08-11 12:45:02 UTC
conflicts when trying to apply to 21.11.x. please provide backport if needed.