Summary: | Batch borrower modifications only affect the current page | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Tools | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | david, jonathan.druart, kyle, martin.renvoize, victor |
Version: | Main | Keywords: | rel_21_05_candidate, rel_21_11_candidate |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Martin Renvoize | Documentation submission: | |
Text to go in the release notes: |
This fixes the batch patron modification tool (Tools > Patrons and circulation > Batch patron modification) so that the changes for all selected patrons are modified. Before this, only the patrons listed on the current page were modified.
|
Version(s) released in: |
22.05.00,21.11.06,21.05.16
|
Circulation function: | |||
Bug Depends on: | 28014 | ||
Bug Blocks: | |||
Attachments: |
Bug 30628: Fix patron selection in batch patron modification tool
Bug 30628: Fix patron selection in batch patron modification tool Bug 30628: Fix patron selection in batch patron modification tool |
Description
Nick Clemens (kidclamp)
2022-04-27 12:12:21 UTC
It's noted on the reports page, that you only send to the batch tools what's currently visible - is that the issue you are seeing? No, the issue is happening in the batch modification itself Created attachment 134205 [details] [review] Bug 30628: Fix patron selection in batch patron modification tool bug 28014 added Datatables to this view, but the form is submitted with only the checkboxes from the first page. Solution adapted from https://stackoverflow.com/questions/33240409/how-to-submit-checkboxes-from-all-pages-with-jquery-datatables Test plan: Have more than 20 cardnumbers, use the batch patron modification tool Select (not all) patrons from the first page and second page Submit the form Notice that the patrons you have selected appear on the confirmation page. Created attachment 134220 [details] [review] Bug 30628: Fix patron selection in batch patron modification tool bug 28014 added Datatables to this view, but the form is submitted with only the checkboxes from the first page. Solution adapted from https://stackoverflow.com/questions/33240409/how-to-submit-checkboxes-from-all-pages-with-jquery-datatables Test plan: Have more than 20 cardnumbers, use the batch patron modification tool Select (not all) patrons from the first page and second page Submit the form Notice that the patrons you have selected appear on the confirmation page. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 134286 [details] [review] Bug 30628: Fix patron selection in batch patron modification tool bug 28014 added Datatables to this view, but the form is submitted with only the checkboxes from the first page. Solution adapted from https://stackoverflow.com/questions/33240409/how-to-submit-checkboxes-from-all-pages-with-jquery-datatables Test plan: Have more than 20 cardnumbers, use the batch patron modification tool Select (not all) patrons from the first page and second page Submit the form Notice that the patrons you have selected appear on the confirmation page. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 22.05, thanks to everybody involved [U+1F984] Pushed to 21.11.x for 21.11.06 Backported: Pushed to 21.05.x branch for 21.05.16 Bugfix with not visual or workflow change. No documentation changes needed. |