To recreate: 1 - Get a list of more than 20 cardnumbers: SELECT cardnumber FROM borrowers LIMIT 50 2 - Enter those cardnumbers into 'Tools-> Batch patron modification' 3 - Add a circulation note 'THIS IS A TEST' 4 - Save 5 - Note results screen has only 20 entries 6 - Confirm only 20 patrons affected
It's noted on the reports page, that you only send to the batch tools what's currently visible - is that the issue you are seeing?
No, the issue is happening in the batch modification itself
Created attachment 134205 [details] [review] Bug 30628: Fix patron selection in batch patron modification tool bug 28014 added Datatables to this view, but the form is submitted with only the checkboxes from the first page. Solution adapted from https://stackoverflow.com/questions/33240409/how-to-submit-checkboxes-from-all-pages-with-jquery-datatables Test plan: Have more than 20 cardnumbers, use the batch patron modification tool Select (not all) patrons from the first page and second page Submit the form Notice that the patrons you have selected appear on the confirmation page.
Created attachment 134220 [details] [review] Bug 30628: Fix patron selection in batch patron modification tool bug 28014 added Datatables to this view, but the form is submitted with only the checkboxes from the first page. Solution adapted from https://stackoverflow.com/questions/33240409/how-to-submit-checkboxes-from-all-pages-with-jquery-datatables Test plan: Have more than 20 cardnumbers, use the batch patron modification tool Select (not all) patrons from the first page and second page Submit the form Notice that the patrons you have selected appear on the confirmation page. Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 134286 [details] [review] Bug 30628: Fix patron selection in batch patron modification tool bug 28014 added Datatables to this view, but the form is submitted with only the checkboxes from the first page. Solution adapted from https://stackoverflow.com/questions/33240409/how-to-submit-checkboxes-from-all-pages-with-jquery-datatables Test plan: Have more than 20 cardnumbers, use the batch patron modification tool Select (not all) patrons from the first page and second page Submit the form Notice that the patrons you have selected appear on the confirmation page. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 22.05, thanks to everybody involved [U+1F984]
Pushed to 21.11.x for 21.11.06
Backported: Pushed to 21.05.x branch for 21.05.16
Bugfix with not visual or workflow change. No documentation changes needed.