Bug 30644

Summary: Cannot delete items
Product: Koha Reporter: Nick Clemens <nick>
Component: CatalogingAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: blocker    
Priority: P5 - low CC: jonathan.druart, kyle, m.de.rooy
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.05.00
Bug Depends on: 29788    
Bug Blocks:    
Attachments: Bug 30644: (bug 29788 follow-up) Make Koha::Item->safe_to_delete use Koha::Result::Boolean
Bug 30644: (bug 29788 follow-up) Make Koha::Item->safe_to_delete use Koha::Result::Boolean

Description Nick Clemens 2022-04-28 12:44:16 UTC
The method Koha::Item->messages is not covered by tests!
Comment 1 Jonathan Druart 2022-04-28 13:44:12 UTC
Shame on me
Comment 2 Jonathan Druart 2022-04-28 13:45:38 UTC
Created attachment 134264 [details] [review]
Bug 30644: (bug 29788 follow-up) Make Koha::Item->safe_to_delete use Koha::Result::Boolean

Fix item deletion

Wrong if/else!

Test plan:
Delete an item
Comment 3 Nick Clemens 2022-04-28 13:54:56 UTC
Created attachment 134265 [details] [review]
Bug 30644: (bug 29788 follow-up) Make Koha::Item->safe_to_delete use Koha::Result::Boolean

Fix item deletion

Wrong if/else!

Test plan:
Delete an item

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 4 Nick Clemens 2022-04-28 13:56:02 UTC
Good catch :-) passing QA
Comment 5 Fridolin Somers 2022-04-28 20:51:15 UTC
Pushed to master for 22.05, thanks to everybody involved 🦄