| Summary: | Holds reminder cronjob (holds_reminder.pl) never uses default letter template | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
| Component: | Command-line Utilities | Assignee: | Kyle M Hall (khall) <kyle> |
| Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | andrew, arthur.suzuki, evelyn, m.de.rooy, robin, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 |
| Patch complexity: | Trivial patch | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: |
22.05.00, 21.11.11
|
Circulation function: | |
| Bug Depends on: | 28514 | ||
| Bug Blocks: | 30666 | ||
| Attachments: |
Bug 30667: Holds reminder cronjob (holds_reminder.pl) never uses default letter template
Bug 30667: Holds reminder cronjob (holds_reminder.pl) never uses default letter template Bug 30667: Holds reminder cronjob (holds_reminder.pl) never uses default letter template |
||
|
Description
Kyle M Hall (khall)
2022-05-03 10:53:25 UTC
Created attachment 134504 [details] [review] Bug 30667: Holds reminder cronjob (holds_reminder.pl) never uses default letter template Bug 28514 changed the way holds_reminder.pl searches for templates, using a direct search for letters, but should be using find_effective_template instead. Now, if a branch specific template does not exist, it will skip that branch. Test Plan: 1) Ensure you only have the default HOLD_REMINDER template 2) Become the koha user using koha-shell 3) Run misc/cronjobs/holds/holds_reminder.pl --days 7 -v 4) Note that the script skips every branch 5) Apply this patch 6) Run the command in step 3 again 7) Note the script doesn't skip over any branches Created attachment 134564 [details] [review] Bug 30667: Holds reminder cronjob (holds_reminder.pl) never uses default letter template Bug 28514 changed the way holds_reminder.pl searches for templates, using a direct search for letters, but should be using find_effective_template instead. Now, if a branch specific template does not exist, it will skip that branch. Test Plan: 1) Ensure you only have the default HOLD_REMINDER template 2) Become the koha user using koha-shell 3) Run misc/cronjobs/holds/holds_reminder.pl --days 7 -v 4) Note that the script skips every branch 5) Apply this patch 6) Run the command in step 3 again 7) Note the script doesn't skip over any branches Signed-off-by: David Nind <david@davidnind.com> Looking here Created attachment 134958 [details] [review] Bug 30667: Holds reminder cronjob (holds_reminder.pl) never uses default letter template Bug 28514 changed the way holds_reminder.pl searches for templates, using a direct search for letters, but should be using find_effective_template instead. Now, if a branch specific template does not exist, it will skip that branch. Test Plan: 1) Ensure you only have the default HOLD_REMINDER template 2) Become the koha user using koha-shell 3) Run misc/cronjobs/holds/holds_reminder.pl --days 7 -v 4) Note that the script skips every branch 5) Apply this patch 6) Run the command in step 3 again 7) Note the script doesn't skip over any branches Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 22.05, thanks to everybody involved [U+1F984] Could this be backported to 21.11? (In reply to evelyn from comment #6) > Could this be backported to 21.11? I've added the RMaint to CC *** Bug 28797 has been marked as a duplicate of this bug. *** pushed to 21.11.x for 21.11.11 Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. |