Summary: | 'Heading-Main' authority-index breaks authority searching in STABLE | ||
---|---|---|---|
Product: | Koha | Reporter: | Chris Cormack <chris> |
Component: | Searching | Assignee: | Jared Camins-Esakov <jcamins> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | critical | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | colin.campbell, frederic.durand, jcamins, koha.sekjal, m.de.rooy, nengard |
Version: | 3.4 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
temporary patch
Patch Revised patch Signed off patch Follow-up patch Revised follow-up patch Revised follow-up patch, adding the Any index signed off follow up |
Description
Chris Cormack
2010-05-21 01:06:04 UTC
*** Bug 3429 has been marked as a duplicate of this bug. *** Sending a patch that includes Heading-Main in authorities bib1 attribute set. Also includes Any in authorities bib1 (was still missing). Also removes temporary fix in AuthoritiesMarc.pm. Please test this patch in 1) OPAC Authorities search: Search in authorities on all three options ($a, main entry, anywhere). Can you get different numbers in all three searches? To have a difference between the first two results, you may have to add your search expression in a $b field somewhere, update zebra and run again. 2) Do the same three searches in Staff Authorities. Search Authorities is looking in $a only, the middle one Main Heading looks in all 1XX fields, the last one looks anywhere. Created attachment 3180 [details] [review] Patch Patch from Bug 5924 seems to resolve this one too. Patch pushed for 5924 is said to fix this as well, please test (In reply to comment #5) > Patch pushed for 5924 is said to fix this as well, please test DO not completely agree. Patch 3072 was more complete. Sending follow up fix for it. Setting status back to signed. Created attachment 3742 [details] [review] Revised patch Revised patch following fix #5924 (In reply to comment #4) > Patch from Bug 5924 seems to resolve this one too. Could you signoff this patch please? It resolves the MARC21 situation. UNIMARC works fine. Created attachment 3775 [details] [review] Signed off patch Tested different search and lots of authority records. Looks good to me! Pushed please test This patch does not cover DOM authorities (In reply to comment #11) > This patch does not cover DOM authorities Please explain: authorities-dom.cfg refers to bib1.att. This patch adds Heading-Main to bib1.att. So what is not covered exactly? ./marc_defs/marc21/authorities/authority-koha-indexdefs.xml ./marc_defs/marc21/authorities/authority-zebra-indexdefs.xsl are both uncovered, and they are the DOM equivalents for record.abs (or a translation mechanism, I can't really tell) In truth, it's the patch for 5924 that does the actual breaking, since it changes SearchAuthorities to use "Heading-Main" instead of "Heading" for 'mainmainentry' marclinks. bib1.att is just fine. (In reply to comment #13) > ./marc_defs/marc21/authorities/authority-koha-indexdefs.xml > ./marc_defs/marc21/authorities/authority-zebra-indexdefs.xsl > are both uncovered, and they are the DOM equivalents for record.abs (or a > translation mechanism, I can't really tell) In truth, it's the patch for 5924 > that does the actual breaking, since it changes SearchAuthorities to use > "Heading-Main" instead of "Heading" for 'mainmainentry' marclinks. bib1.att is > just fine. Thanks. It seems that we should add Heading-Main in these two files also. Can take a look Monday.. Created attachment 3847 [details] [review] Follow-up patch This patch adds the Heading-Main index to the two config files for MARC21 Authority DOM indexing. Note that the first patch has already been signed off, and it is only the follow-up patch that requires sign-off. *** Bug 6128 has been marked as a duplicate of this bug. *** Created attachment 3848 [details] [review] Revised follow-up patch Created attachment 3864 [details] [review] Revised follow-up patch, adding the Any index This revised patch adds both Heading-Main and Any indexes to the DOM MARC21 Authorities configuration. Re-assigning to me since marcelr's patch was pushed, and I'm responsible for the proposed fix for MARC21 DOM authorities. follow up signed off Created attachment 3937 [details] [review] signed off follow up Follow up pushed, please test This seems to be working to me. I'm going to close. Reopen if there's a problem. |