Summary: | t/db_dependent/Koha/BackgroundJob.t fails on D9 and D10 | ||
---|---|---|---|
Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
Component: | Test Suite | Assignee: | Marcel de Rooy <m.de.rooy> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | jonathan.druart, m.de.rooy |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.05.00
|
|
Bug Depends on: | 30360 | ||
Bug Blocks: | |||
Attachments: | Bug 30734: Fix BackgroundJob.t |
Description
Fridolin Somers
2022-05-11 18:30:45 UTC
Created attachment 134920 [details] [review] Bug 30734: Fix BackgroundJob.t Added test for empty string or undefined. We could still consider evaling the json operations. Test plan: Run t/db_dependent/Koha/BackgroundJob.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Trivial: self SO Why only on D9 and D10? (In reply to Jonathan Druart from comment #3) > Why only on D9 and D10? Apparently, Fridolin saw it there. But it could be removed imo. (In reply to Marcel de Rooy from comment #4) > (In reply to Jonathan Druart from comment #3) > > Why only on D9 and D10? > > Apparently, Fridolin saw it there. But it could be removed imo. I don't recreate on D11, so I think it's valid for D9 and D10 only, but I don't understand why (In reply to Jonathan Druart from comment #5) > (In reply to Marcel de Rooy from comment #4) > > (In reply to Jonathan Druart from comment #3) > > > Why only on D9 and D10? > > > > Apparently, Fridolin saw it there. But it could be removed imo. > > I don't recreate on D11, so I think it's valid for D9 and D10 only, but I > don't understand why Could be related to the JSON module version on D11 Could we say it is passed QA ? (In reply to Fridolin Somers from comment #7) > Could we say it is passed QA ? It is a trivial patch and you are RM :) I want my jenkins green. Passed QA Pushed to master for 22.05, thanks to everybody involved 🦄 |