Bug 30734 - t/db_dependent/Koha/BackgroundJob.t fails on D9 and D10
Summary: t/db_dependent/Koha/BackgroundJob.t fails on D9 and D10
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Marcel de Rooy
QA Contact: Testopia
URL:
Keywords:
Depends on: 30360
Blocks:
  Show dependency tree / graph
 
Reported: 2022-05-11 18:30 UTC by Fridolin Somers
Modified: 2023-12-28 20:43 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.05.00
Circulation function:

Attachments
Bug 30734: Fix BackgroundJob.t (1.20 KB, patch)
2022-05-12 08:40 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2022-05-11 18:30:45 UTC 
t/db_dependent/Koha/BackgroundJob.t fails on D9 and D10 :

koha_1       | #   Failed test 'No tests run for subtest "decoded_data() and set_encoded_data() tests"'
koha_1       | #   at t/db_dependent/Koha/BackgroundJob.t line 169.
koha_1       | hash- or arrayref expected (not a simple scalar, use allow_nonref to allow this) at /kohadevbox/koha/Koha/BackgroundJob.pm line 262.
koha_1       | # Looks like your test exited with 255 just after 4.
Comment 1 Marcel de Rooy 2022-05-12 08:40:18 UTC 
Created attachment 134920 [details] [review]
Bug 30734: Fix BackgroundJob.t

Added test for empty string or undefined. We could still consider
evaling the json operations.

Test plan:
Run t/db_dependent/Koha/BackgroundJob.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Marcel de Rooy 2022-05-12 08:40:38 UTC 
Trivial: self SO
Comment 3 Jonathan Druart 2022-05-12 09:27:01 UTC 
Why only on D9 and D10?
Comment 4 Marcel de Rooy 2022-05-12 09:33:12 UTC 
(In reply to Jonathan Druart from comment #3)
> Why only on D9 and D10?

Apparently, Fridolin saw it there. But it could be removed imo.
Comment 5 Jonathan Druart 2022-05-12 09:44:24 UTC 
(In reply to Marcel de Rooy from comment #4)
> (In reply to Jonathan Druart from comment #3)
> > Why only on D9 and D10?
> 
> Apparently, Fridolin saw it there. But it could be removed imo.

I don't recreate on D11, so I think it's valid for D9 and D10 only, but I don't understand why
Comment 6 Marcel de Rooy 2022-05-12 09:53:45 UTC 
(In reply to Jonathan Druart from comment #5)
> (In reply to Marcel de Rooy from comment #4)
> > (In reply to Jonathan Druart from comment #3)
> > > Why only on D9 and D10?
> > 
> > Apparently, Fridolin saw it there. But it could be removed imo.
> 
> I don't recreate on D11, so I think it's valid for D9 and D10 only, but I
> don't understand why

Could be related to the JSON module version on D11
Comment 7 Fridolin Somers 2022-05-13 02:10:40 UTC 
Could we say it is passed QA ?
Comment 8 Marcel de Rooy 2022-05-13 06:02:07 UTC 
(In reply to Fridolin Somers from comment #7)
> Could we say it is passed QA ?

It is a trivial patch and you are RM :)
Comment 9 Fridolin Somers 2022-05-13 07:52:48 UTC 
I want my jenkins green.
Passed QA
Comment 10 Fridolin Somers 2022-05-13 08:17:36 UTC 
Pushed to master for 22.05, thanks to everybody involved ﷐[U+1F984]﷑