Bug 30743

Summary: Adding a library does not update the transport cost matrix
Product: Koha Reporter: Nick Clemens (kidclamp) <nick>
Component: Architecture, internals, and plumbingAssignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: andrew
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Description Nick Clemens (kidclamp) 2022-05-12 18:45:05 UTC
To test:
1 - View the transport cost matrix
2 - Add some values
3 - Add a new library
4 - View the matrix, not new library appears disabled in all columns
5 - Run the holds queue - there is a warning:
Use of uninitialized value in numeric ne (!=) at /usr/share/koha/lib/C4/HoldsQueue.pm line 811.
6 - Hit save on the matrix
7 - View the DB and note new library is disabled in all columns
8 - Run holds queue - they don't get any holds

IDK the correct default, but this seems problematic, maybe we need to add a warning when adding libraries to system, or disable them by default actually?
Comment 1 Andrew Fuerste-Henry 2022-05-12 18:48:33 UTC
> 4 - View the matrix, not new library appears disabled in all columns

Really important clarification here, the new library *appears* to have disabled all transfers to and from the library, but none of those restrictions are actually enforced. Instead, the library is treated as if those transfers are allowed at a cost of zero.

Whatever the correct default is, we should make the display and behavior consistent.