Bug 30743 - Adding a library does not update the transport cost matrix
Summary: Adding a library does not update the transport cost matrix
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-12 18:45 UTC by Nick Clemens (kidclamp)
Modified: 2022-05-12 18:48 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2022-05-12 18:45:05 UTC
To test:
1 - View the transport cost matrix
2 - Add some values
3 - Add a new library
4 - View the matrix, not new library appears disabled in all columns
5 - Run the holds queue - there is a warning:
Use of uninitialized value in numeric ne (!=) at /usr/share/koha/lib/C4/HoldsQueue.pm line 811.
6 - Hit save on the matrix
7 - View the DB and note new library is disabled in all columns
8 - Run holds queue - they don't get any holds

IDK the correct default, but this seems problematic, maybe we need to add a warning when adding libraries to system, or disable them by default actually?
Comment 1 Andrew Fuerste-Henry 2022-05-12 18:48:33 UTC
> 4 - View the matrix, not new library appears disabled in all columns

Really important clarification here, the new library *appears* to have disabled all transfers to and from the library, but none of those restrictions are actually enforced. Instead, the library is treated as if those transfers are allowed at a cost of zero.

Whatever the correct default is, we should make the display and behavior consistent.