| Summary: | The last two skips on Jenkins for Koha_ExternalContent_RecordedBooks.t | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
| Component: | Test Suite | Assignee: | Chris Cormack <chris> |
| Status: | CLOSED INVALID | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | fridolin.somers, nick, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
|
Description
Marcel de Rooy
2022-05-14 12:46:27 UTC
t_db_dependent_Koha_ExternalContent_RecordedBooks_t 39 ms 0 2 1 3 The only test we do on Jenkins, is the use_ok on the module Reference to debian package libwebservice-ils-perl_0.17-1_all.deb Nick or Tomas,
Do you know if this is actually used somewhere?
Koha::ExternalContent and friends (for Overdrive or RecordedBooks).
The design of all this is a bit curious to me.
This unit test Koha_ExternalContent_RecordedBooks.t makes not much sense imo. We are normally only use_ok ing the module Koha::ExternalContent::RecordedBooks here since the ENV vars will be empty. We could miss that test ;)
And skipping two other tests:
$user_agent_string =~ m/^Koha/
This is filled in ExternalContent.pm and will not be a surprise.
And: ok( $client->search({ query => 'school' }), 'search' )
Actually we are testing external connectivity here? The result does not seem to matter much?
We should not rely on external connectivity. And dont need to test the (external) underlying Webservice::ILS stuff. You could make a simple mock object for it?
Any reasons to keep this test in its current form ?
|