Bug 30757 - The last two skips on Jenkins for Koha_ExternalContent_RecordedBooks.t
Summary: The last two skips on Jenkins for Koha_ExternalContent_RecordedBooks.t
Status: RESOLVED INVALID
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Chris Cormack
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-14 12:46 UTC by Marcel de Rooy
Modified: 2023-06-18 10:30 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2022-05-14 12:46:27 UTC

    
Comment 1 Marcel de Rooy 2022-05-14 12:56:45 UTC
t_db_dependent_Koha_ExternalContent_RecordedBooks_t	39 ms	0		2		1		3	

The only test we do on Jenkins, is the use_ok on the module

Reference to debian package libwebservice-ils-perl_0.17-1_all.deb
Comment 2 Marcel de Rooy 2022-05-18 06:31:45 UTC
Nick or Tomas,
Do you know if this is actually used somewhere?
Koha::ExternalContent and friends (for Overdrive or RecordedBooks).
The design of all this is a bit curious to me.

This unit test Koha_ExternalContent_RecordedBooks.t makes not much sense imo. We are normally only use_ok ing the module Koha::ExternalContent::RecordedBooks here since the ENV vars will be empty. We could miss that test ;)

And skipping two other tests:
$user_agent_string =~ m/^Koha/
This is filled in ExternalContent.pm and will not be a surprise.

And: ok( $client->search({ query => 'school' }), 'search' )
Actually we are testing external connectivity here? The result does not seem to matter much?
We should not rely on external connectivity. And dont need to test the (external) underlying Webservice::ILS stuff. You could make a simple mock object for it?

Any reasons to keep this test in its current form ?
Comment 3 Katrin Fischer 2023-06-18 10:30:34 UTC
The file has been removed by bug 33697.