Bug 30766

Summary:	Typo: Cannot cancel receipt. Possible reasons :
Product:	Koha	Reporter:	Katrin Fischer <katrin.fischer>
Component:	Templates	Assignee:	Danyon Sewell <danyonsewell>
Status:	CLOSED FIXED	QA Contact:	Testopia <testopia>
Severity:	trivial
Priority:	P5 - low	CC:	arthur.suzuki, chris, danyonsewell, lucas, victor
Version:	Main	Keywords:	Academy
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	String patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	22.11.00, 22.05.04, 21.11.11
Circulation function:
Attachments:	Bug 30766: extra space in Cannot cancel receipt string. Tested patch Bug 30766: extra space in Cannot cancel receipt string

Description Katrin Fischer 2022-05-15 11:48:17 UTC

koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt:88

Cannot cancel receipt. Possible reasons␠:

The space before : should be removed.

Comment 1 Danyon Sewell 2022-07-07 23:00:23 UTC

Created attachment 137338 [details] [review]
Bug 30766: extra space in Cannot cancel receipt string.

TEST PLAN:

1. Trigger the Cannot cancel receipt error in invoices OR look at the
amended string to see the additional space has been removed.

Sponsored by Catalyst IT

Comment 2 Chris Cormack 2022-07-07 23:20:14 UTC

Created attachment 137344 [details] [review]
Tested patch

Comment 3 Katrin Fischer 2022-07-08 08:14:55 UTC

Created attachment 137374 [details] [review]
Bug 30766: extra space in Cannot cancel receipt string

TEST PLAN:

1. Trigger the Cannot cancel receipt error in invoices OR look at the
amended string to see the additional space has been removed.

Sponsored by Catalyst IT

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Comment 4 Katrin Fischer 2022-07-08 08:16:04 UTC

Thank you, Danyon! Going straight to PQA here.

Comment 5 Tomás Cohen Arazi (tcohen) 2022-07-08 18:26:29 UTC

Pushed to master for 22.11.

Nice work everyone, thanks!

Comment 6 Lucas Gass (lukeg) 2022-08-12 16:42:42 UTC

Backported to 22.05.x for 22.05.04

Comment 7 Arthur Suzuki 2022-08-16 12:47:57 UTC

in 21.11.x for 21.11.11

Comment 8 Victor Grousset/tuxayo 2022-08-19 22:54:26 UTC

Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document, marking resolved.