Summary: | Use patron-title.inc in member-flags template | ||
---|---|---|---|
Product: | Koha | Reporter: | Martin Renvoize <martin.renvoize> |
Component: | Templates | Assignee: | Martin Renvoize <martin.renvoize> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | david, lucas, tomascohen |
Version: | Main | Keywords: | Academy |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This enhancement updates the template for the patron set permissions page (members/member-flags.pl) to use the patron-title.inc include wherever patron names are referenced. This is used to format patron name names consistently, rather than a custom format each time the patron name is referenced. The patron name is now displayed as "Set permissions for firstname lastname (patron card number), instead of "Set permissions for lastname, firstname".
|
Version(s) released in: |
22.11.00, 22.05.03
|
Bug Depends on: | |||
Bug Blocks: | 30617 | ||
Attachments: |
Bug 30806: Migrate to patron-title in member-flags
Bug 30806: Migrate to patron-title in member-flags Bug 30806: Migrate to patron-title in member-flags |
Description
Martin Renvoize
2022-05-19 11:33:43 UTC
Created attachment 135200 [details] [review] Bug 30806: Migrate to patron-title in member-flags This patch updates the member-flags template to use the patron-title.inc include wherever patron names are referenced. Test plan 1) Navigate to a patron and click through to edit their permissions 2) Note how the patron name displays in the title, breadcrump and headings 3) Apply the patch and reload the page 4) Confirm the patron name still appears in each location and is consistently formatted and linked as you would expect Created attachment 135284 [details] [review] Bug 30806: Migrate to patron-title in member-flags This patch updates the member-flags template to use the patron-title.inc include wherever patron names are referenced. Test plan 1) Navigate to a patron and click through to edit their permissions 2) Note how the patron name displays in the title, breadcrump and headings 3) Apply the patch and reload the page 4) Confirm the patron name still appears in each location and is consistently formatted and linked as you would expect Signed-off-by: David Nind <david@davidnind.com> Created attachment 135469 [details] [review] Bug 30806: Migrate to patron-title in member-flags This patch updates the member-flags template to use the patron-title.inc include wherever patron names are referenced. Test plan 1) Navigate to a patron and click through to edit their permissions 2) Note how the patron name displays in the title, breadcrump and headings 3) Apply the patch and reload the page 4) Confirm the patron name still appears in each location and is consistently formatted and linked as you would expect Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 22.11. Nice work everyone, thanks! Backported to 22.05.x for 22.05.03 |