Bug 30617 - [OMNIBUS] We should consistently use includes for patron name display
Summary: [OMNIBUS] We should consistently use includes for patron name display
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords: Academy
: 22279 (view as bug list)
Depends on: 30651 21978 30806 30807
Blocks: 30568
  Show dependency tree / graph
 
Reported: 2022-04-26 07:18 UTC by Martin Renvoize (ashimema)
Modified: 2024-04-26 18:37 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize (ashimema) 2022-04-26 07:18:55 UTC 
Our templates are littered with various invocations of `[% patron.surname %], [% patron.firstname %]` and similar in varying orders and varying levels of detail (with or without cardnumber, with or without title, surname first or firstname first, linked and unlinked).

We have two ways of constructing a patron display block, patron-title.inc tt include and js-patron-format.inc for use in JS based displays.

We should congregate our templates around these two includes so that we can make our display consistent throughout with perhaps just a couple of display variations.. short and long forms perhaps?
Comment 1 Katrin Fischer 2022-04-26 11:41:45 UTC 
I guess this calls for a lot of smaller bugs in a way trying to clean up various templates.
Comment 2 Martin Renvoize (ashimema) 2022-04-27 06:50:24 UTC 
*** Bug 22279 has been marked as a duplicate of this bug. ***