Bug 30845

Summary: OMNIBUS: Move holds checks into CanBookBeReserved/CanItemBeReserved
Product: Koha Reporter: Nick Clemens (kidclamp) <nick>
Component: Hold requestsAssignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: david, gmcharlt
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 20985, 25408, 30846, 32702, 33087    
Bug Blocks:    

Description Nick Clemens (kidclamp) 2022-05-25 12:13:27 UTC
We have a number of holds checks:
not for loan
opacitemholds
OPACHoldsIfAvailableAtPickup

which are only checked in the script, and not our modules

The api uses CanBook/CanItem BeReserved for checking validity of holds and is missing these checks

We need to move the checks and cover them with unit tests