Bug 30845 - OMNIBUS: Move holds checks into CanBookBeReserved/CanItemBeReserved
Summary: OMNIBUS: Move holds checks into CanBookBeReserved/CanItemBeReserved
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
: 33801 (view as bug list)
Depends on: 20985 25408 32702 30846 33087
Blocks:
  Show dependency treegraph
 
Reported: 2022-05-25 12:13 UTC by Nick Clemens (kidclamp)
Modified: 2025-05-14 07:40 UTC (History)
3 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2022-05-25 12:13:27 UTC
We have a number of holds checks:
not for loan
opacitemholds
OPACHoldsIfAvailableAtPickup

which are only checked in the script, and not our modules

The api uses CanBook/CanItem BeReserved for checking validity of holds and is missing these checks

We need to move the checks and cover them with unit tests
Comment 1 Arthur Suzuki 2025-05-14 07:40:16 UTC
*** Bug 33801 has been marked as a duplicate of this bug. ***