|
Description
Tomás Cohen Arazi (tcohen)
2022-05-26 14:16:34 UTC
Created attachment 135384 [details] [review] Bug 30855: Rename /import => /import_batches This patch renames the route to make it consistent for future additions. To test: 1. Run $ git grep 'matches/chosen' => FAIL: all occurences use /api/v1/import/ 2. Apply this patch 3. Run: $ git grep 'matches/chosen' => SUCCESS: All occurences have '/api/v1/import_batches/' 4. Run: $ kshell k$ prove t/db_dependent/api/v1/import_record_matches.t => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 135385 [details] [review] Bug 30855: (follow-up) Rewrite tests using Basic authentication Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 135412 [details] [review] Bug 30855: Rename /import => /import_batches This patch renames the route to make it consistent for future additions. To test: 1. Run $ git grep 'matches/chosen' => FAIL: all occurences use /api/v1/import/ 2. Apply this patch 3. Run: $ git grep 'matches/chosen' => SUCCESS: All occurences have '/api/v1/import_batches/' 4. Run: $ kshell k$ prove t/db_dependent/api/v1/import_record_matches.t => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Created attachment 135413 [details] [review] Bug 30855: (follow-up) Rewrite tests using Basic authentication Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Can we have a comment or a variable so the magic number 13 for flags isn't magic anymore? Otherwise, looks good for QA. Created attachment 135515 [details] [review] Bug 30855: (follow-up) Rewrite tests using Basic authentication Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Created attachment 135585 [details] [review] Bug 30855: Rename /import => /import_batches This patch renames the route to make it consistent for future additions. To test: 1. Run $ git grep 'matches/chosen' => FAIL: all occurences use /api/v1/import/ 2. Apply this patch 3. Run: $ git grep 'matches/chosen' => SUCCESS: All occurences have '/api/v1/import_batches/' 4. Run: $ kshell k$ prove t/db_dependent/api/v1/import_record_matches.t => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 135586 [details] [review] Bug 30855: (follow-up) Rewrite tests using Basic authentication Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 22.11. Nice work everyone, thanks! Pushed to 22.05.x for 22.05.01 (In reply to Lucas Gass from comment #10) > Pushed to 22.05.x for 22.05.01 Thanks! depends on 30854 (released in 22.05) not relevant for 21.11.x |