Bug 30855 - Rename /import => /import_batches
Summary: Rename /import => /import_batches
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: REST API (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: Tomás Cohen Arazi (tcohen)
QA Contact: Victor Grousset/tuxayo
URL:
Keywords:
Depends on: 30854
Blocks:
  Show dependency tree / graph
 
Reported: 2022-05-26 14:16 UTC by Tomás Cohen Arazi (tcohen)
Modified: 2023-06-08 22:26 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00, 22.05.01
Circulation function:

Attachments
Bug 30855: Rename /import => /import_batches (6.42 KB, patch)
2022-05-26 14:37 UTC, Tomás Cohen Arazi (tcohen) 		Details | Diff | Splinter Review
Bug 30855: (follow-up) Rewrite tests using Basic authentication (7.08 KB, patch)
2022-05-26 14:37 UTC, Tomás Cohen Arazi (tcohen) 		Details | Diff | Splinter Review
Bug 30855: Rename /import => /import_batches (6.47 KB, patch)
2022-05-26 23:03 UTC, David Nind 		Details | Diff | Splinter Review
Bug 30855: (follow-up) Rewrite tests using Basic authentication (7.13 KB, patch)
2022-05-26 23:03 UTC, David Nind 		Details | Diff | Splinter Review
Bug 30855: (follow-up) Rewrite tests using Basic authentication (7.37 KB, patch)
2022-05-31 17:38 UTC, Tomás Cohen Arazi (tcohen) 		Details | Diff | Splinter Review
Bug 30855: Rename /import => /import_batches (6.52 KB, patch)
2022-06-02 14:19 UTC, Nick Clemens (kidclamp) 		Details | Diff | Splinter Review
Bug 30855: (follow-up) Rewrite tests using Basic authentication (7.42 KB, patch)
2022-06-02 14:19 UTC, Nick Clemens (kidclamp) 		Details | Diff | Splinter Review
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi (tcohen) 2022-05-26 14:16:34 UTC 
It will keep things more consistent once we add routes to deal with import batches.
Comment 1 Tomás Cohen Arazi (tcohen) 2022-05-26 14:37:51 UTC 
Created attachment 135384 [details] [review]
Bug 30855: Rename /import => /import_batches

This patch renames the route to make it consistent for future additions.

To test:
1. Run
   $ git grep 'matches/chosen'
=> FAIL: all occurences use /api/v1/import/
2. Apply this patch
3. Run:
   $ git grep 'matches/chosen'
=> SUCCESS: All occurences have '/api/v1/import_batches/'
4. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/import_record_matches.t
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 2 Tomás Cohen Arazi (tcohen) 2022-05-26 14:37:56 UTC 
Created attachment 135385 [details] [review]
Bug 30855: (follow-up) Rewrite tests using Basic authentication

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 3 David Nind 2022-05-26 23:03:01 UTC 
Created attachment 135412 [details] [review]
Bug 30855: Rename /import => /import_batches

This patch renames the route to make it consistent for future additions.

To test:
1. Run
   $ git grep 'matches/chosen'
=> FAIL: all occurences use /api/v1/import/
2. Apply this patch
3. Run:
   $ git grep 'matches/chosen'
=> SUCCESS: All occurences have '/api/v1/import_batches/'
4. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/import_record_matches.t
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2022-05-26 23:03:06 UTC 
Created attachment 135413 [details] [review]
Bug 30855: (follow-up) Rewrite tests using Basic authentication

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 Victor Grousset/tuxayo 2022-05-31 00:34:56 UTC 
Can we have a comment or a variable so the magic number 13 for flags isn't magic anymore?

Otherwise, looks good for QA.
Comment 6 Tomás Cohen Arazi (tcohen) 2022-05-31 17:38:30 UTC 
Created attachment 135515 [details] [review]
Bug 30855: (follow-up) Rewrite tests using Basic authentication

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: David Nind <david@davidnind.com>
Comment 7 Nick Clemens (kidclamp) 2022-06-02 14:19:10 UTC 
Created attachment 135585 [details] [review]
Bug 30855: Rename /import => /import_batches

This patch renames the route to make it consistent for future additions.

To test:
1. Run
   $ git grep 'matches/chosen'
=> FAIL: all occurences use /api/v1/import/
2. Apply this patch
3. Run:
   $ git grep 'matches/chosen'
=> SUCCESS: All occurences have '/api/v1/import_batches/'
4. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/import_record_matches.t
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 8 Nick Clemens (kidclamp) 2022-06-02 14:19:14 UTC 
Created attachment 135586 [details] [review]
Bug 30855: (follow-up) Rewrite tests using Basic authentication

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 9 Tomás Cohen Arazi (tcohen) 2022-06-02 16:44:20 UTC 
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 10 Lucas Gass (lukeg) 2022-06-10 16:51:03 UTC 
Pushed to 22.05.x for 22.05.01
Comment 11 Tomás Cohen Arazi (tcohen) 2022-06-10 17:55:09 UTC 
(In reply to Lucas Gass from comment #10)
> Pushed to 22.05.x for 22.05.01

Thanks!
Comment 12 Arthur Suzuki 2022-06-21 13:37:29 UTC 
depends on 30854 (released in 22.05) not relevant for 21.11.x