|
Description
Lucas Gass (lukeg)
2022-05-26 16:32:59 UTC
Created attachment 135393 [details] [review] Bug 30858: Add serial enumeration/chronology to item search To test: 1. Apply patch 2. Go to Catalog > Item search and do a search for items that you know contain a items.enumchron 3. The result set should now show the items.enumchron 4. Make sure you can properly "Export results to.." Status changed to Failed QA because of 3 and 4. Testing notes (koha-testing-docker): 1. I added some values to 952$h for a couple of items for some records. 2. Using the item search, the column "Serial enumeration" is now shown, and values entered show - the sorting and filtering also works. 3. Export results to: for CSV - column header is exported, but data is not (used Vol X Issue X in items, as well as just a plain number). 4. Reviewing the patch, for a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt line 327, "items_barcode" is used as the id for the table heading - should this be something else? 5. Found it interesting that the CSV is exported with a semicolon as the separator, I can log this as another bug if you think it is necessary. 5. Alternatively (and probably a bigger change) is to configure what columns are shown using data tables, and also let the columns be selected and configured using Administration > Additional parameters > Table settings. For example, like the holdings table in the view details view for a record. I'm not sure how this works, but I imagine it would be a lot more work. If this was changed, it could also use the Export function which gives additional options, but I'm not sure how you would get the barcode export. Created attachment 137849 [details] [review] Bug 30858: Add serial enumeration/chronology to item search To test: 1. Apply patch 2. Go to Catalog > Item search and do a search for items that you know contain a items.enumchron 3. The result set should now show the items.enumchron 4. Make sure you can properly "Export results to.." Created attachment 137850 [details] [review] Bug 30589: (follow-up) Add enumchron to CSV export and fix CSS class I borrowed your bug, Lucas and hopefully fixed the issues David noted for good :) Ah, and there is already a bug for adding the column configuration: Bug 23565 - Add columns configuration and export options to item search results Created attachment 137888 [details] [review] Bug 30858: Add serial enumeration/chronology to item search To test: 1. Apply patch 2. Go to Catalog > Item search and do a search for items that you know contain a items.enumchron 3. The result set should now show the items.enumchron 4. Make sure you can properly "Export results to.." Signed-off-by: David Nind <david@davidnind.com> Created attachment 137889 [details] [review] Bug 30589: (follow-up) Add enumchron to CSV export and fix CSS class https://bugs.koha-community.org/show_bug.cgi?id=30858 Signed-off-by: David Nind <david@davidnind.com> Created attachment 137956 [details] [review] Bug 30858: Add serial enumeration/chronology to item search To test: 1. Apply patch 2. Go to Catalog > Item search and do a search for items that you know contain a items.enumchron 3. The result set should now show the items.enumchron 4. Make sure you can properly "Export results to.." Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 137957 [details] [review] Bug 30858: (follow-up) Add enumchron to CSV export and fix CSS class Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> All works well, QA scripts are happy. I fixed the bug number in the follow-up. Passing QA Pushed to master for 22.11. Nice work everyone, thanks! Enhancement will not be backported to 22.05.x series |