Summary: | Don't skip tests if Test::Deep is not installed | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Test Suite | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Victor Grousset/tuxayo <victor> |
Severity: | normal | ||
Priority: | P5 - low | CC: | lucas, tomascohen, victor |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.11.00, 22.05.01
|
|
Circulation function: | |||
Bug Depends on: | 29883 | ||
Bug Blocks: | |||
Attachments: |
Bug 30870: Don't skip tests if Test::Deep if not installed
Bug 30870: Don't skip tests if Test::Deep if not installed Bug 30870: Don't skip tests if Test::Deep if not installed |
Description
Jonathan Druart
2022-05-31 09:29:41 UTC
Created attachment 135483 [details] [review] Bug 30870: Don't skip tests if Test::Deep if not installed We are using Test::Deep in different tests, but from t/db_dependent/Koha.t the tests are skippted if the module is not installed. We must assume the module is installed Test plan: prove t/db_dependent/Koha.t should return green in ktd Created attachment 135513 [details] [review] Bug 30870: Don't skip tests if Test::Deep if not installed We are using Test::Deep in different tests, but from t/db_dependent/Koha.t the tests are skippted if the module is not installed. We must assume the module is installed Test plan: prove t/db_dependent/Koha.t should return green in ktd Signed-off-by: David Nind <david@davidnind.com> Created attachment 135514 [details] [review] Bug 30870: Don't skip tests if Test::Deep if not installed We are using Test::Deep in different tests, but from t/db_dependent/Koha.t the tests are skippted if the module is not installed. We must assume the module is installed Test plan: prove t/db_dependent/Koha.t should return green in ktd Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Works, qa script happy, code looks good, passing QA :) Pushed to master for 22.11. Nice work everyone, thanks! Pushed to 22.05.x for 22.05.01 Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. And nothing to document, resolving. |