Bug 30924

I am getting several errors and issues when testing bug 30823 - BEFORE applying the patch.

I thought these were fixed with some of the recent recalls bugs that were pushed to master.

I'm not sure whether separate bugs are required, or just one to look at what is causing these. In the interim, I've created this bug.

Scenario/settings using koha-testing-docker (up-to-date with master):
- UseRecalls system preference: set to 'Use'.
- RecallsLog system preference: set to 'Log'.
- Circulation and fines rules:
  . Recalls allowed (total) = 5
  . Recalls per record (count) = 2
  . On shelf recalls allowed = 'If any unavailable'
  . Recall due date interval (day) = 3
  . Recall overdue fine amount = 5
  . Recall pickup period (day) = 2
- Patron B: Mary Burton (Midway)
- Patron A: Henry Acevedo (Midway)
- Record used to place recalls on: Programming Perl (biblionumber = 262, one item = 39999000011418, home library = Centerville)

TLDR:
- Log viewer: Error on log viewer for recalls once there is are logged recalls transactions
- Transfers for recalls: error on transfers to receive
- After check in and waiting for pickup: actions to cancel recall on several pages do not work

Error 1: Setup and place a recall - log viewer error
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

I get this error using the log viewer limited to the recalls module - recall placed, no other actions.

Template process failed: undef error - The method Koha::Recall->item_level_recall is not covered by tests!

Trace begun at /kohadevbox/koha/Koha/Object.pm line 875
Koha::Object::AUTOLOAD('Koha::Recall=HASH(0x55d076a68a48)') called at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt line 379
eval {...} at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt line 379
eval {...} at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt line 409
eval {...} at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt line 18
Template::Provider::__ANON__('Template::Context=HASH(0x55d074a2b5f0)') called at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Document.pm line 163
eval {...} at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Document.pm line 161
....

Error 2: Viewing the check out page > checkouts tab for Mary - after recall placed
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

No checkouts are listed, sits on "Loading... you may continue scanning" in a floating box at the bottom of the page, with "Loading..." showing in the center of the table. Does not show other items checked out.

The details page > checkouts tab is the same.

Error 3: If a transfer is required
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Step 1: Check in the item (39999000011418) > Transfer to Midway required > Confirm recall and transfer.
- Mary: checkouts list is now displaying
- Henry: recalls tab showing "In transit to Midway"
- Circulation > Recalls > Recalls queue: showing "In transit to Midway"
- Circulation > Recalls > Recalls to pull: listed with button to "Cancel recall and return to: Centerville

Step 2: Transfer to Midway
- Change library to Midway
- Ciculation > Transfers > Transfers to receive: get this error:

Template process failed: undef error - The method Koha::Recall->borrowernumber is not covered by tests!

Trace begun at /kohadevbox/koha/Koha/Object.pm line 875
Koha::Object::AUTOLOAD('Koha::Recall=HASH(0x559d07b59d00)') called at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstoreceive.tt line 93
eval {...} at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstoreceive.tt line 93
eval {...} at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstoreceive.tt line 108
eval {...} at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstoreceive.tt line 112
eval {...} at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstoreceive.tt line 18
....

Step 3: Check in item (with library set to Midway)
- Modal window with "Recall at Midway + Confirm recall"
- Circulation > Recalls > Recalls awaiting pickup: listed
- Circulation > Transfers > Transfers to receive: no errors
- Record detail page in staff interface: showing as "Waiting at Midway since..."
- Henry: recalls tab on patron page for check out and details sections - shows as "Ready for pickup"
- Mary: nothing shown (as expected)

Step 4: Checkout item - works as expected, 

But wait, there's more!

1. Once a recall is made, and checked in: 
   a. On the staff interface item details page > recalls section - selecting from the Actions drop down list/button "Cancel recall and return to Centerville" does nothing. 
   b. However, selecting the tick box and selecting "Cancel selected recalls" works. 
   c. In addition, after you press "Cancel...":
     - the URL changes to http://127.0.0.1:8081/cgi-bin/koha/recalls/request.pl 
     - clicking on normal (or any other tab gives you the message "The record you requested does not exist ()." 
     - URL is http://127.0.0.1:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=
 
2. Once a recall is made, and checked in: 
   . From Circulation > Recalls > Recalls queue: same as 1a and 1b.

3. Once a recall is made, and checked in: 
   . From Circulation > Recalls > Recalls to pull: select "Cancel recall and return to: Centerville: generates this error:
   
   DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Data truncated for column 'reason' at row 1 at /kohadevbox/koha/Koha/Object.pm line 170
 at /usr/share/perl5/DBIx/Class/Exception.pm line 77
 .....

4. On the patron details > recalls tab page for Henry, selecting Actions > "Cancel recall and return to: Cenetrville" does nothing (same as 1a).