Bug 30965

Summary: Add patron autocomplete search to curbside pickups
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: CirculationAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: alissa.desaintlaurent, black23, caroline.cyr-la-rose, gmcharlt, koha, kyle.m.hall, lucas, sonia.bouis
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: Sponsored Patch complexity: Small patch
Documentation contact: Caroline Cyr La Rose Documentation submission: https://gitlab.com/koha-community/koha-manual/-/merge_requests/617/
Text to go in the release notes:
Version(s) released in:
22.11.00
Circulation function:
Bug Depends on: 30578, 30650    
Bug Blocks: 37983, 38676    
Attachments: Bug 30965: Add patron autocomplete search to curbside pickups
Bug 30965: Add patron autocomplete search to curbside pickups
Bug 30965: Add patron autocomplete search to curbside pickups
Bug 30965: Add a 'x' to go back to the patron search
Bug 30965: Add patron autocomplete search to curbside pickups
Bug 30965: Add a 'x' to go back to the patron search

Description Jonathan Druart 2022-06-15 08:30:10 UTC
So far it's only possible to search for patrons by cardnumber. We should add the regular patron autocomplete search to allow search by surname and firstname.
Comment 1 Jonathan Druart 2022-06-27 13:23:52 UTC
Created attachment 136583 [details] [review]
Bug 30965: Add patron autocomplete search to curbside pickups

Prior to this patch librarians had to know the cardnumber to search for
patron. Now it's possible to search using the default patron
autocomplete search (name, cardnumber, etc.)

Test plan:
Confirm that you can search for a patron without their cardnumber,
select it and create a curbside pickup

Sponsored-by: Association KohaLa - https://koha-fr.org/
Comment 2 Jonathan Druart 2022-06-27 13:27:26 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2022-07-04 15:21:21 UTC
Created attachment 137097 [details] [review]
Bug 30965: Add patron autocomplete search to curbside pickups

Prior to this patch librarians had to know the cardnumber to search for
patron. Now it's possible to search using the default patron
autocomplete search (name, cardnumber, etc.)

Test plan:
Confirm that you can search for a patron without their cardnumber,
select it and create a curbside pickup

Sponsored-by: Association KohaLa - https://koha-fr.org/
Comment 4 Koha Team University Lyon 3 2022-07-07 09:48:33 UTC
Hi,
tested on a sandbox on the top of BZ30650 and it works as expected.
On the "schedule pickup" tab of the curbside pickups table, you can search the patron with his name and you tye 3 letters, you have an autocompletion.

Thanks
Sonia
Comment 5 Jonathan Druart 2022-07-07 13:06:36 UTC
Created attachment 137309 [details] [review]
Bug 30965: Add patron autocomplete search to curbside pickups

Prior to this patch librarians had to know the cardnumber to search for
patron. Now it's possible to search using the default patron
autocomplete search (name, cardnumber, etc.)

Test plan:
Confirm that you can search for a patron without their cardnumber,
select it and create a curbside pickup

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha@univ-lyon3.fr>
Comment 6 Katrin Fischer 2022-07-30 13:28:28 UTC
My problem with the patron search here is that you get 'stuck' on it.

Search for a patron, pick it - names were all similar, it's not the right one!

There is no way to reset the form. You'd have to schedule a curbside pickup (which sends an email) and remove it again to get out of it.

Can we have some kind of reset button to get back to search?

Not for this bug, but how do people feel about having a way to open an 'advanced search' (like the normal pop-up) with a button if needed? We've had complaints form libraries with lots of patrons with very similar names in the past and this might help them.
Comment 7 Jonathan Druart 2022-07-31 06:14:52 UTC
Created attachment 138402 [details] [review]
Bug 30965: Add a 'x' to go back to the patron search
Comment 8 Jonathan Druart 2022-07-31 06:15:40 UTC
Is that what you wanted?
Comment 9 Katrin Fischer 2022-07-31 20:36:14 UTC
Created attachment 138420 [details] [review]
Bug 30965: Add patron autocomplete search to curbside pickups

Prior to this patch librarians had to know the cardnumber to search for
patron. Now it's possible to search using the default patron
autocomplete search (name, cardnumber, etc.)

Test plan:
Confirm that you can search for a patron without their cardnumber,
select it and create a curbside pickup

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha@univ-lyon3.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 10 Katrin Fischer 2022-07-31 20:36:18 UTC
Created attachment 138421 [details] [review]
Bug 30965: Add a 'x' to go back to the patron search

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 11 Katrin Fischer 2022-07-31 20:36:34 UTC
(In reply to Jonathan Druart from comment #8)
> Is that what you wanted?

Yes, that's much better - thx!
Comment 12 Tomás Cohen Arazi (tcohen) 2022-08-01 12:11:13 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 13 Lucas Gass (lukeg) 2022-09-29 15:05:19 UTC
Missing dependencies for 22.05.x, no backport