Bug 37983 - "Search a patron" box no longer has auto focus
Summary: "Search a patron" box no longer has auto focus
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Lucas Gass (lukeg)
URL:
Keywords:
Depends on: 30965
Blocks:
  Show dependency tree / graph
 
Reported: 2024-09-23 10:06 UTC by Jonathan Druart
Modified: 2024-11-18 22:33 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00,24.05.06
Circulation function:

Attachments
Bug 37983: Restore auto-focus on patron input when "Schedule a pickup" is selected (1.40 KB, patch)
2024-09-23 10:08 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 37983: Restore auto-focus on patron input when "Schedule a pickup" is selected (1.45 KB, patch)
2024-09-24 03:06 UTC, Phil Ringnalda 		Details | Diff | Splinter Review
Bug 37983: Restore auto-focus on patron input when "Schedule a pickup" is selected (1.50 KB, patch)
2024-09-24 16:29 UTC, Lucas Gass (lukeg) 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2024-09-23 10:06:37 UTC 
In the curbside pickup module, when the "Schedule a pickup" tab is selected we expect the patron search box to get the focus. But it has been broken bug 30965 (which changed the id of the input).
Comment 1 Jonathan Druart 2024-09-23 10:08:57 UTC 
Created attachment 171873 [details] [review]
Bug 37983: Restore auto-focus on patron input when "Schedule a pickup" is selected

In the curbside pickup module, when the "Schedule a pickup" tab is selected we expect
the patron search box to get the focus. But it has been broken bug 30965 (which changed the id of the input).

Test plan:
Setup curbside pickup for your library
Go to Circulation > Curbside pickups
Click the last tab
Notice that you can directly search for a patron, the input has the
focus
Comment 2 Phil Ringnalda 2024-09-24 03:06:34 UTC 
Created attachment 171915 [details] [review]
Bug 37983: Restore auto-focus on patron input when "Schedule a pickup" is selected

In the curbside pickup module, when the "Schedule a pickup" tab is selected we expect
the patron search box to get the focus. But it has been broken bug 30965 (which changed the id of the input).

Test plan:
Setup curbside pickup for your library
Go to Circulation > Curbside pickups
Click the last tab
Notice that you can directly search for a patron, the input has the
focus

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Testing notes: the tabs looking like a line of jammed-together links is
bug 37761
Comment 3 Lucas Gass (lukeg) 2024-09-24 16:29:53 UTC 
Created attachment 171948 [details] [review]
Bug 37983: Restore auto-focus on patron input when "Schedule a pickup" is selected

In the curbside pickup module, when the "Schedule a pickup" tab is selected we expect
the patron search box to get the focus. But it has been broken bug 30965 (which changed the id of the input).

Test plan:
Setup curbside pickup for your library
Go to Circulation > Curbside pickups
Click the last tab
Notice that you can directly search for a patron, the input has the
focus

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 4 Martin Renvoize (ashimema) 2024-09-30 14:34:32 UTC 
Thanks for all the hard work!

Pushed to main for the next 24.11.00 release as RM Assistant
Comment 5 Lucas Gass (lukeg) 2024-11-18 22:33:21 UTC 
Backported to 24.05.x for upcoming 24.05.06