| Summary: | holdst columns don't match actual columns in 'Holds waiting' | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Sara Brown <sbrown> |
| Component: | Staff interface | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | arthur.suzuki, gmcharlt, jonathan.druart, l.m.harrison, lucy.vaux-harvey, martin.renvoize, victor |
| Version: | 21.11 | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27868 | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
21.11.11
|
|
| Circulation function: | |||
| Bug Depends on: | 23678 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 30970: Add checkbox column to holdst and holdso
Bug 30970: Add checkbox column to holdst and holdso Bug 30970: Add checkbox column to holdst and holdso Bug 30970: Add checkbox column to holdst and holdso |
||
|
Description
Sara Brown
2022-06-15 16:41:59 UTC
Looks ok for me on master. Same for me, I think the issue is not in master. Maybe only in 21.11 and other older versions? Created attachment 137618 [details] [review] Bug 30970: Add checkbox column to holdst and holdso This patch adds the missing checkbox column to the columns_settings configuration file. The field was added unconditionally to the tables in bug 23678 and then consequently fixed in master as part of bug 27868 which being an ehancement wont be backported. This patch simply lifts the relevant part of the fix from bug 27868 to apply just to the 21.11.x branch. Created attachment 137625 [details] [review] Bug 30970: Add checkbox column to holdst and holdso This patch adds the missing checkbox column to the columns_settings configuration file. The field was added unconditionally to the tables in bug 23678 and then consequently fixed in master as part of bug 27868 which being an ehancement wont be backported. This patch simply lifts the relevant part of the fix from bug 27868 to apply just to the 21.11.x branch. Signed-off-by: Lucy Harrison <l.m.harrison@lboro.ac.uk> Thankyou for the quick signoff Lucy, I've added your signature to the patch itself now too for our history. Created attachment 137626 [details] [review] Bug 30970: Add checkbox column to holdst and holdso This patch adds the missing checkbox column to the columns_settings configuration file. The field was added unconditionally to the tables in bug 23678 and then consequently fixed in master as part of bug 27868 which being an ehancement wont be backported. This patch simply lifts the relevant part of the fix from bug 27868 to apply just to the 21.11.x branch. Signed-off-by: David Nind <david@davidnind.com> Created attachment 137796 [details] [review] Bug 30970: Add checkbox column to holdst and holdso This patch adds the missing checkbox column to the columns_settings configuration file. The field was added unconditionally to the tables in bug 23678 and then consequently fixed in master as part of bug 27868 which being an ehancement wont be backported. This patch simply lifts the relevant part of the fix from bug 27868 to apply just to the 21.11.x branch. Signed-off-by: Lucy Harrison <l.m.harrison@lboro.ac.uk> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Works (I'm taking the two SO to not have to get a 21.11 env), qa script happy, code looks good, same as on master, passing QA :) pushed to 21.11.x for 21.11.11, thx! Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. I don't think this requires an update to the documentation, marked Resolved. |