The columns selected to hide by default in 'Table settings' for holdst aren't lining up with the actual columns hidden. For example: -In holdst, select columns home_library and current_location to be hidden by default -In the 'Holds waiting' table, see that Patron and Home library are hidden by default. Current location is showing by default. -To hide current_location and home_library by default, I need to select shelving_location and current_location in 'Table settings'
Looks ok for me on master.
Same for me, I think the issue is not in master. Maybe only in 21.11 and other older versions?
Created attachment 137618 [details] [review] Bug 30970: Add checkbox column to holdst and holdso This patch adds the missing checkbox column to the columns_settings configuration file. The field was added unconditionally to the tables in bug 23678 and then consequently fixed in master as part of bug 27868 which being an ehancement wont be backported. This patch simply lifts the relevant part of the fix from bug 27868 to apply just to the 21.11.x branch.
Created attachment 137625 [details] [review] Bug 30970: Add checkbox column to holdst and holdso This patch adds the missing checkbox column to the columns_settings configuration file. The field was added unconditionally to the tables in bug 23678 and then consequently fixed in master as part of bug 27868 which being an ehancement wont be backported. This patch simply lifts the relevant part of the fix from bug 27868 to apply just to the 21.11.x branch. Signed-off-by: Lucy Harrison <l.m.harrison@lboro.ac.uk>
Thankyou for the quick signoff Lucy, I've added your signature to the patch itself now too for our history.
Created attachment 137626 [details] [review] Bug 30970: Add checkbox column to holdst and holdso This patch adds the missing checkbox column to the columns_settings configuration file. The field was added unconditionally to the tables in bug 23678 and then consequently fixed in master as part of bug 27868 which being an ehancement wont be backported. This patch simply lifts the relevant part of the fix from bug 27868 to apply just to the 21.11.x branch. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 137796 [details] [review] Bug 30970: Add checkbox column to holdst and holdso This patch adds the missing checkbox column to the columns_settings configuration file. The field was added unconditionally to the tables in bug 23678 and then consequently fixed in master as part of bug 27868 which being an ehancement wont be backported. This patch simply lifts the relevant part of the fix from bug 27868 to apply just to the 21.11.x branch. Signed-off-by: Lucy Harrison <l.m.harrison@lboro.ac.uk> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Works (I'm taking the two SO to not have to get a 21.11 env), qa script happy, code looks good, same as on master, passing QA :)
pushed to 21.11.x for 21.11.11, thx!
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.
I don't think this requires an update to the documentation, marked Resolved.