Description
David Nind
2022-06-15 19:08:06 UTC
Created attachment 136118 [details] [review] Bug 30971: Recalls log viewer error This patch addresses the itemnumber and biblionumber attributes for recalls having been renamed. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 136119 [details] [review] Bug 30971: (follow-up) Fix one more occurence To test: 1. Run: $ git grep 'recall.itemnumber' => SUCCESS: No more occurences 2. Run: $ git grep 'recall.biblionumber' => SUCCESS: No more occurences 3. Run: $ git grep 'recall\->biblionumber' => SUCCESS: No more occurences 4. Run: $ git grep 'recall\->itemnumber' => FAIL: One standing occurence 5. Apply this patch 6. Repeat 4 => SUCCESS: No more occurences 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 136120 [details] [review] Bug 30971: (follow-up) Fix recall.branchcode occurences This fixes a couple cases actually. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 136121 [details] [review] Bug 30971: Recalls log viewer error This patch addresses the itemnumber and biblionumber attributes for recalls having been renamed. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Created attachment 136122 [details] [review] Bug 30971: (follow-up) Fix one more occurence To test: 1. Run: $ git grep 'recall.itemnumber' => SUCCESS: No more occurences 2. Run: $ git grep 'recall.biblionumber' => SUCCESS: No more occurences 3. Run: $ git grep 'recall\->biblionumber' => SUCCESS: No more occurences 4. Run: $ git grep 'recall\->itemnumber' => FAIL: One standing occurence 5. Apply this patch 6. Repeat 4 => SUCCESS: No more occurences 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Thanks Tomás! There are no more occurrences of the git grep queries after the patches are applied, and the log viewer now works for recalls. David (In reply to David Nind from comment #6) > Thanks Tomás! > > There are no more occurrences of the git grep queries after the patches are > applied, and the log viewer now works for recalls. > > David David, thanks to you. I also did this: Generated a 'recalls' file: $ cat recalls borrowernumber recalldate biblionumber branchcode cancellationdate recallnotes itemnumber waitingdate expirationdate old item_level_recall and then: $ for i in $(cat ~/recalls) ; do \ git grep "recall\.$i" | grep -v translator; \ git grep "recall\->$i" | grep -v translator; \ done And no more results. Chances are that in some places variables could've been named differently. Hopefully QA didn't allow that :-D (In reply to David Nind from comment #6) > Thanks Tomás! > > There are no more occurrences of the git grep queries after the patches are > applied, and the log viewer now works for recalls. > > David You missed one of the patches to SO Created attachment 136123 [details] [review] Bug 30971: (follow-up) Fix recall.branchcode occurences This fixes a couple cases actually. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> https://bugs.koha-community.org/show_bug.cgi?id=30917 (In reply to Tomás Cohen Arazi from comment #8) > You missed one of the patches to SO I was too quick! Now signed off as well. Created attachment 136139 [details] [review] Bug 30971: Recalls log viewer error This patch addresses the itemnumber and biblionumber attributes for recalls having been renamed. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 136140 [details] [review] Bug 30971: (follow-up) Fix one more occurence To test: 1. Run: $ git grep 'recall.itemnumber' => SUCCESS: No more occurences 2. Run: $ git grep 'recall.biblionumber' => SUCCESS: No more occurences 3. Run: $ git grep 'recall\->biblionumber' => SUCCESS: No more occurences 4. Run: $ git grep 'recall\->itemnumber' => FAIL: One standing occurence 5. Apply this patch 6. Repeat 4 => SUCCESS: No more occurences 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 136141 [details] [review] Bug 30971: (follow-up) Fix recall.branchcode occurences This fixes a couple cases actually. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> All works as expected now, thanks for following through on all this Tomas. PQA Pushed to master for 22.11. Nice work everyone, thanks! backported to 22.05.x for 22.05.01 |