Bug 30990

Summary: Terminology: DefaultHoldPickupLocation
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: TemplatesAssignee: Katrin Fischer <katrin.fischer>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: trivial    
Priority: P5 - low CC: arthur.suzuki, jonathan.druart, lucas
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: String patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00, 22.05.04
Circulation function:
Bug Depends on: 23659    
Bug Blocks:    
Attachments: Bug 30990: Fix DefaultHoldPickupLocation system preference description
Bug 30990: Fix DefaultHoldPickupLocation system preference description
Bug 30990: Fix DefaultHoldPickupLocation system preference description

Description Katrin Fischer 2022-06-17 20:07:25 UTC
The description of the DefaultHoldPickupLocation uses some false terminology:

staff client should be staff interface
branch should be library
Comment 1 Katrin Fischer 2022-06-17 20:21:36 UTC
Created attachment 136308 [details] [review]
Bug 30990: Fix DefaultHoldPickupLocation system preference description

Changes:
* branch to library
* staff client to staff interface
* adds an ending .

To test:
- Compare system preference descrpition before and after the
  patch was applied.
Comment 2 Lucas Gass (lukeg) 2022-06-17 20:47:47 UTC
Created attachment 136309 [details] [review]
Bug 30990: Fix DefaultHoldPickupLocation system preference description

Changes:
* branch to library
* staff client to staff interface
* adds an ending .

To test:
- Compare system preference descrpition before and after the
  patch was applied.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Jonathan Druart 2022-07-05 07:30:25 UTC
Created attachment 137143 [details] [review]
Bug 30990: Fix DefaultHoldPickupLocation system preference description

Changes:
* branch to library
* staff client to staff interface
* adds an ending .

To test:
- Compare system preference descrpition before and after the
  patch was applied.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Jonathan Druart 2022-07-05 07:31:28 UTC
Should we add a QA check to catch "staff client", "home branch" and "holding branch"? If so please open an issue on the qa-test-tools project.
Comment 5 Katrin Fischer 2022-07-05 10:41:35 UTC
On one hand it would be nice, but we can only catch the versions we know should not be used and would have to limit it translatable strings (we have plenty of branch, reserve etc. in source code). Not sure if that's doable/worth the hassle?
Comment 6 Tomás Cohen Arazi (tcohen) 2022-07-05 12:59:30 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 7 Lucas Gass (lukeg) 2022-08-09 22:20:16 UTC
Backported to 22.05.x for 22.05.04
Comment 8 Arthur Suzuki 2022-08-12 07:55:55 UTC
syspref DefaultHoldPickupLocation doesn't exist in 21.11. won't backport