Bug 31021

Summary:	Part of C4::Search::searchResults() is only for staff interface
Product:	Koha	Reporter:	Fridolin Somers <fridolin.somers>
Component:	Searching	Assignee:	Fridolin Somers <fridolin.somers>
Status:	ASSIGNED ---	QA Contact:	Testopia <testopia>
Severity:	normal
Priority:	P5 - low	CC:	dcook
Version:	Main
Hardware:	All
OS:	All
See Also:	https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Bug Depends on:
Bug Blocks:	15262

Description Fridolin Somers 2022-06-23 06:18:50 UTC

Since non-XSLT has been removed, looks like part of C4::Search::searchResults() is only for staff interface.
It whould be a better performance to skip it for OPAC.

It concerns items loops @onloan_items_loop, @other_items_loop, @available_items_loop, starting around :
https://git.koha-community.org/Koha-community/Koha/src/commit/7a7bee59021728a30c631e2ee51f9b7778217a9f/C4/Search.pm#L1833

We should try to add a 'unless $is_opac'.
Maybe we could go further and move this to catalogue/search.pl, it would be more clear.

Comment 1 David Cook 2022-06-24 00:02:35 UTC

I haven't deep dived this one (yet) but (re)moving unnecessary code sounds good.