Bug 31021 - Part of C4::Search::searchResults() is only for staff interface
Summary: Part of C4::Search::searchResults() is only for staff interface
Status: ASSIGNED
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Fridolin Somers
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 15262
  Show dependency tree / graph
 
Reported: 2022-06-23 06:18 UTC by Fridolin Somers
Modified: 2022-06-24 00:02 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2022-06-23 06:18:50 UTC 
Since non-XSLT has been removed, looks like part of C4::Search::searchResults() is only for staff interface.
It whould be a better performance to skip it for OPAC.

It concerns items loops @onloan_items_loop, @other_items_loop, @available_items_loop, starting around :
https://git.koha-community.org/Koha-community/Koha/src/commit/7a7bee59021728a30c631e2ee51f9b7778217a9f/C4/Search.pm#L1833

We should try to add a 'unless $is_opac'.
Maybe we could go further and move this to catalogue/search.pl, it would be more clear.
Comment 1 David Cook 2022-06-24 00:02:35 UTC 
I haven't deep dived this one (yet) but (re)moving unnecessary code sounds good.