Summary: | Amounts in cashup summary modal no longer properly formatted | ||
---|---|---|---|
Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
Component: | Staff interface | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | normal | ||
Priority: | P5 - low | CC: | arthur.suzuki, david, gmcharlt, information, lucas, sally.healey, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31121 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This fixes the formatting of amounts on the cashup summary modal (it uses the existing format_price JS include to format prices). For example, the amount for a product was formatted as 15 instead of 15.00.
|
Version(s) released in: |
22.11.00, 22.05.04, 21.11.11
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 31039 | ||
Attachments: |
Bug 31038: Fix price formating in cashup summary
Before and after screenshots Bug 31038: Fix price formating in cashup summary Bug 31038: Fix price formating in cashup summary |
Description
Martin Renvoize (ashimema)
2022-06-24 09:40:53 UTC
Created attachment 136486 [details] [review] Bug 31038: Fix price formating in cashup summary This patch uses the existing format_price JS include to format prices in the cashup summary modal Test plan 1) Create some transactions and a cashup 2) View the cashup summary modal and confirm amounts are not nicely formatted 3) Apply patch 4) Confirm amounts in cashup summary modals are now nicely formatted Created attachment 136489 [details]
Before and after screenshots
Screenshots before and after patch applied.
Created attachment 136490 [details] [review] Bug 31038: Fix price formating in cashup summary This patch uses the existing format_price JS include to format prices in the cashup summary modal Test plan 1) Create some transactions and a cashup 2) View the cashup summary modal and confirm amounts are not nicely formatted 3) Apply patch 4) Confirm amounts in cashup summary modals are now nicely formatted Signed-off-by: David Nind <david@davidnind.com> Thanks David :) Created attachment 137401 [details] [review] Bug 31038: Fix price formating in cashup summary This patch uses the existing format_price JS include to format prices in the cashup summary modal Test plan 1) Create some transactions and a cashup 2) View the cashup summary modal and confirm amounts are not nicely formatted 3) Apply patch 4) Confirm amounts in cashup summary modals are now nicely formatted Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Pushed to master for 22.11. Nice work everyone, thanks! Backported to 22.05.x for 22.05.04 21.11.x for 21.11.11 Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. |