Bug 31038 - Amounts in cashup summary modal no longer properly formatted
Summary: Amounts in cashup summary modal no longer properly formatted
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Martin Renvoize
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks: 31039
  Show dependency treegraph
 
Reported: 2022-06-24 09:40 UTC by Martin Renvoize
Modified: 2023-06-08 22:26 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the formatting of amounts on the cashup summary modal (it uses the existing format_price JS include to format prices). For example, the amount for a product was formatted as 15 instead of 15.00.
Version(s) released in:
22.11.00, 22.05.04, 21.11.11


Attachments
Bug 31038: Fix price formating in cashup summary (3.61 KB, patch)
2022-06-24 10:38 UTC, Martin Renvoize
Details | Diff | Splinter Review
Before and after screenshots (42.00 KB, application/pdf)
2022-06-24 13:11 UTC, David Nind
Details
Bug 31038: Fix price formating in cashup summary (3.66 KB, patch)
2022-06-24 13:12 UTC, David Nind
Details | Diff | Splinter Review
Bug 31038: Fix price formating in cashup summary (3.71 KB, patch)
2022-07-08 09:50 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2022-06-24 09:40:53 UTC
The formatting of amounts in the cashup summary modal are no longer formatted correctly.
Comment 1 Martin Renvoize 2022-06-24 10:38:06 UTC
Created attachment 136486 [details] [review]
Bug 31038: Fix price formating in cashup summary

This patch uses the existing format_price JS include to format prices in
the cashup summary modal

Test plan
1) Create some transactions and a cashup
2) View the cashup summary modal and confirm amounts are not nicely
   formatted
3) Apply patch
4) Confirm amounts in cashup summary modals are now nicely formatted
Comment 2 David Nind 2022-06-24 13:11:22 UTC
Created attachment 136489 [details]
Before and after screenshots

Screenshots before and after patch applied.
Comment 3 David Nind 2022-06-24 13:12:36 UTC
Created attachment 136490 [details] [review]
Bug 31038: Fix price formating in cashup summary

This patch uses the existing format_price JS include to format prices in
the cashup summary modal

Test plan
1) Create some transactions and a cashup
2) View the cashup summary modal and confirm amounts are not nicely
   formatted
3) Apply patch
4) Confirm amounts in cashup summary modals are now nicely formatted

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 Martin Renvoize 2022-06-24 14:23:48 UTC
Thanks David :)
Comment 5 Katrin Fischer 2022-07-08 09:50:18 UTC
Created attachment 137401 [details] [review]
Bug 31038: Fix price formating in cashup summary

This patch uses the existing format_price JS include to format prices in
the cashup summary modal

Test plan
1) Create some transactions and a cashup
2) View the cashup summary modal and confirm amounts are not nicely
   formatted
3) Apply patch
4) Confirm amounts in cashup summary modals are now nicely formatted

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 6 Tomás Cohen Arazi 2022-07-08 18:15:37 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 7 Lucas Gass 2022-08-12 16:06:13 UTC
Backported to 22.05.x for 22.05.04
Comment 8 Arthur Suzuki 2022-08-16 12:11:17 UTC
21.11.x for 21.11.11
Comment 9 Victor Grousset/tuxayo 2022-08-19 22:46:35 UTC
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document, marking resolved.