| Summary: | Regression: date due removed from staff search results | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | arthur.suzuki, bdaeuber, david, e.betemps, jonathan.druart, lucas, martin.renvoize, victor |
| Version: | Main | Keywords: | regression |
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This fixes a regression introduced in Koha 21.11 that inadvertently removed the date due in the staff interface search results.
|
Version(s) released in: |
22.11.00, 22.05.04, 21.11.11
|
| Circulation function: | |||
| Bug Depends on: | 28321 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 31071: Regression: date due removed from staff search results
Bug 31071: Regression: date due removed from staff search results Screenshot - due date in search results before and after patch applied Screenshot - due date in search results before and after patch applied Bug 31071: Regression: date due removed from staff search results Bug 31071: Regression: date due removed from staff search results |
||
|
Description
Fridolin Somers
2022-06-30 08:50:03 UTC
This one is for you Owen, the line Fridolin pointed in comment 0 has been removed from master by your patch. Created attachment 137645 [details] [review] Bug 31071: Regression: date due removed from staff search results This patch corrects a regression caused by Bug 28321, which inadvertently removed the date due from output of item information in each search result. To test, apply the patch and perform a catalog search which will return some results which are checked out and some which aren't. Confirm that the checked out items show the date due correctly. Created attachment 137657 [details] [review] Bug 31071: Regression: date due removed from staff search results This patch corrects a regression caused by Bug 28321, which inadvertently removed the date due from output of item information in each search result. To test, apply the patch and perform a catalog search which will return some results which are checked out and some which aren't. Confirm that the checked out items show the date due correctly. Signed-off-by: David Nind <david@davidnind.com> Created attachment 137660 [details]
Screenshot - due date in search results before and after patch applied
I have signed off, but note that the display seems slightly "off" - see the screenshots.
Not sure if there is a better way to format this.
Created attachment 137661 [details]
Screenshot - due date in search results before and after patch applied
I have signed off, but note that the display seems slightly "off" - see the screenshots.
Not sure if there is a better way to format this.
(Have re-added as a PDF)
Due date is displayed but instead of this display : Centerville Audio Visual • 1 Due: 07/19/2022 Music Could we rather get something like : Centerville Audio Visual • 1 Music Due: 07/19/2022 (In reply to Emmanuel Bétemps from comment #6) > Could we rather get something like This patch fixes a regression, so it doesn't make changes to the order of the elements. A separate bug could be filed to talk about improvements to the display. Created attachment 137686 [details] [review] Bug 31071: Regression: date due removed from staff search results This patch corrects a regression caused by Bug 28321, which inadvertently removed the date due from output of item information in each search result. To test, apply the patch and perform a catalog search which will return some results which are checked out and some which aren't. Confirm that the checked out items show the date due correctly. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> Created attachment 137696 [details] [review] Bug 31071: Regression: date due removed from staff search results This patch corrects a regression caused by Bug 28321, which inadvertently removed the date due from output of item information in each search result. To test, apply the patch and perform a catalog search which will return some results which are checked out and some which aren't. Confirm that the checked out items show the date due correctly. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Fixes the regression, passing QA Pushed to master for 22.11. Nice work everyone, thanks! Backported to 22.05.x for 22.05.04 backported to 21.11.x for 21.11.11 Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. |