Bug 31071 - Regression: date due removed from staff search results
Summary: Regression: date due removed from staff search results
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Martin Renvoize
URL:
Keywords: regression
Depends on: 28321
Blocks:
  Show dependency treegraph
 
Reported: 2022-06-30 08:50 UTC by Fridolin Somers
Modified: 2023-06-08 22:26 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes a regression introduced in Koha 21.11 that inadvertently removed the date due in the staff interface search results.
Version(s) released in:
22.11.00, 22.05.04, 21.11.11


Attachments
Bug 31071: Regression: date due removed from staff search results (2.76 KB, patch)
2022-07-12 17:27 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 31071: Regression: date due removed from staff search results (2.81 KB, patch)
2022-07-12 19:48 UTC, David Nind
Details | Diff | Splinter Review
Screenshot - due date in search results before and after patch applied (57.91 KB, application/vnd.oasis.opendocument.text)
2022-07-12 19:57 UTC, David Nind
Details
Screenshot - due date in search results before and after patch applied (44.17 KB, application/pdf)
2022-07-12 20:00 UTC, David Nind
Details
Bug 31071: Regression: date due removed from staff search results (2.95 KB, patch)
2022-07-13 19:13 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 31071: Regression: date due removed from staff search results (3.01 KB, patch)
2022-07-14 09:19 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2022-06-30 08:50:03 UTC
Bug 28321 changed the TT of results page.
It removed date due for onloan items :
https://git.koha-community.org/Koha-community/Koha/src/branch/21.05.x/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt#L617
Comment 1 Jonathan Druart 2022-07-12 10:20:55 UTC
This one is for you Owen, the line Fridolin pointed in comment 0 has been removed from master by your patch.
Comment 2 Owen Leonard 2022-07-12 17:27:01 UTC
Created attachment 137645 [details] [review]
Bug 31071: Regression: date due removed from staff search results

This patch corrects a regression caused by Bug 28321, which
inadvertently removed the date due from output of item information in
each search result.

To test, apply the patch and perform a catalog search which will return
some results which are checked out and some which aren't. Confirm that
the checked out items show the date due correctly.
Comment 3 David Nind 2022-07-12 19:48:48 UTC
Created attachment 137657 [details] [review]
Bug 31071: Regression: date due removed from staff search results

This patch corrects a regression caused by Bug 28321, which
inadvertently removed the date due from output of item information in
each search result.

To test, apply the patch and perform a catalog search which will return
some results which are checked out and some which aren't. Confirm that
the checked out items show the date due correctly.

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2022-07-12 19:57:02 UTC Comment hidden (obsolete)
Comment 5 David Nind 2022-07-12 20:00:27 UTC
Created attachment 137661 [details]
Screenshot - due date in search results before and after patch applied

I have signed off, but note that the display seems slightly "off" - see the screenshots.

Not sure if there is a better way to format this.

(Have re-added as a PDF)
Comment 6 Emmanuel Bétemps 2022-07-13 06:58:14 UTC
Due date is displayed but instead of this display :

Centerville
Audio Visual
 • 1 Due: 07/19/2022 Music


Could we rather get something like :


Centerville
Audio Visual
 • 1 Music
Due: 07/19/2022
Comment 7 Owen Leonard 2022-07-13 16:48:16 UTC
(In reply to Emmanuel Bétemps from comment #6)
> Could we rather get something like

This patch fixes a regression, so it doesn't make changes to the order of the elements. A separate bug could be filed to talk about improvements to the display.
Comment 8 ByWater Sandboxes 2022-07-13 19:13:07 UTC
Created attachment 137686 [details] [review]
Bug 31071: Regression: date due removed from staff search results

This patch corrects a regression caused by Bug 28321, which
inadvertently removed the date due from output of item information in
each search result.

To test, apply the patch and perform a catalog search which will return
some results which are checked out and some which aren't. Confirm that
the checked out items show the date due correctly.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com>
Comment 9 Martin Renvoize 2022-07-14 09:19:02 UTC
Created attachment 137696 [details] [review]
Bug 31071: Regression: date due removed from staff search results

This patch corrects a regression caused by Bug 28321, which
inadvertently removed the date due from output of item information in
each search result.

To test, apply the patch and perform a catalog search which will return
some results which are checked out and some which aren't. Confirm that
the checked out items show the date due correctly.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 10 Martin Renvoize 2022-07-14 09:19:33 UTC
Fixes the regression, passing QA
Comment 11 Tomás Cohen Arazi 2022-07-18 17:42:36 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 12 Lucas Gass 2022-08-15 15:25:37 UTC
Backported to 22.05.x for 22.05.04
Comment 13 Arthur Suzuki 2022-08-16 14:15:49 UTC
backported to 21.11.x for 21.11.11
Comment 14 Victor Grousset/tuxayo 2022-08-19 23:22:07 UTC
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document, marking resolved.