Bug 31082

Summary: Add tooltip to buttons when item bundles cannot be changed while checked out
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: CirculationAssignee: Jonathan Druart <jonathan.druart>
Status: RESOLVED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: gmcharlt, jonathan.druart, kyle.m.hall, lucas, martin.renvoize, victor
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.02,22.11.08
Bug Depends on: 33817    
Bug Blocks:    
Attachments: Bug 31082: Add tooltip to buttons when item bundles cannot be changed while checked out
Bug 31082: Add tooltip to buttons when item bundles cannot be changed while checked out
Bug 31082: Add tooltip to buttons when item bundles cannot be changed while checked out
Bug 31082: (follow-up) same for "remove" action button on bundle item list
Bug 31082: (follow-up) same for "remove" action button on bundle item list
Bug 31082: Make the string translatable
Bug 31082: Add tooltip to buttons when item bundles cannot be changed while checked out
Bug 31082: (follow-up) same for "remove" action button on bundle item list
Bug 31082: Make the string translatable
Bug 31082: (QA follow-up) Fix translation - we are in a .tt not in a .js file

Description Katrin Fischer 2022-07-01 13:44:35 UTC
When an item bundle is checked out, the composition of the bundle can not be changed (items added or removed). The buttons are greyed out/inactive.

It would be nice to add a tooltip explaining why the bundle cannot be altered.
Comment 1 Jonathan Druart 2023-05-25 09:47:01 UTC
Created attachment 151661 [details] [review]
Bug 31082: Add tooltip to buttons when item bundles cannot be changed while checked out
Comment 2 Martin Renvoize 2023-05-25 11:01:42 UTC
Created attachment 151669 [details] [review]
Bug 31082: Add tooltip to buttons when item bundles cannot be changed while checked out

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 3 Martin Renvoize 2023-05-25 11:02:20 UTC
It's great to see these little improvements getting done, thanks for working on them Jonathan and my apologies for not having managed to get to them yet :(
Comment 4 Victor Grousset/tuxayo 2023-06-18 22:47:37 UTC
Created attachment 152455 [details] [review]
Bug 31082: Add tooltip to buttons when item bundles cannot be changed while checked out

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 5 Victor Grousset/tuxayo 2023-06-18 22:47:40 UTC
Created attachment 152456 [details] [review]
Bug 31082: (follow-up) same for "remove" action button on bundle item list
Comment 6 Victor Grousset/tuxayo 2023-06-18 22:53:06 UTC
1st patch: Works, makes sense, QA script happy, code looks good but it missed a thing. It doesn't include the remove action button on the bundle item list.

So here is a follow-up. Need someone else to test and a confirmation that I did the change in a nice way.
Comment 7 Jonathan Druart 2023-07-07 09:42:39 UTC
Created attachment 153140 [details] [review]
Bug 31082: (follow-up) same for "remove" action button on bundle item list

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 8 Jonathan Druart 2023-07-07 09:42:42 UTC
Created attachment 153141 [details] [review]
Bug 31082: Make the string translatable

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 9 Katrin Fischer 2023-07-09 15:34:09 UTC
Created attachment 153231 [details] [review]
Bug 31082: Add tooltip to buttons when item bundles cannot be changed while checked out

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 10 Katrin Fischer 2023-07-09 15:34:12 UTC
Created attachment 153232 [details] [review]
Bug 31082: (follow-up) same for "remove" action button on bundle item list

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 11 Katrin Fischer 2023-07-09 15:34:15 UTC
Created attachment 153233 [details] [review]
Bug 31082: Make the string translatable

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 12 Katrin Fischer 2023-07-09 15:34:18 UTC
Created attachment 153234 [details] [review]
Bug 31082: (QA follow-up) Fix translation - we are in a .tt not in a .js file

Just changing from two to one underscore.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 13 Tomás Cohen Arazi 2023-07-12 17:31:44 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 14 Martin Renvoize 2023-07-18 10:08:16 UTC
Thanks for all the hard work!

Pushed to 23.05.x for the next release
Comment 15 Matt Blenkinsop 2023-07-18 15:21:07 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x