When an item bundle is checked out, the composition of the bundle can not be changed (items added or removed). The buttons are greyed out/inactive. It would be nice to add a tooltip explaining why the bundle cannot be altered.
Created attachment 151661 [details] [review] Bug 31082: Add tooltip to buttons when item bundles cannot be changed while checked out
Created attachment 151669 [details] [review] Bug 31082: Add tooltip to buttons when item bundles cannot be changed while checked out Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
It's great to see these little improvements getting done, thanks for working on them Jonathan and my apologies for not having managed to get to them yet :(
Created attachment 152455 [details] [review] Bug 31082: Add tooltip to buttons when item bundles cannot be changed while checked out Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Created attachment 152456 [details] [review] Bug 31082: (follow-up) same for "remove" action button on bundle item list
1st patch: Works, makes sense, QA script happy, code looks good but it missed a thing. It doesn't include the remove action button on the bundle item list. So here is a follow-up. Need someone else to test and a confirmation that I did the change in a nice way.
Created attachment 153140 [details] [review] Bug 31082: (follow-up) same for "remove" action button on bundle item list Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 153141 [details] [review] Bug 31082: Make the string translatable Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 153231 [details] [review] Bug 31082: Add tooltip to buttons when item bundles cannot be changed while checked out Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Created attachment 153232 [details] [review] Bug 31082: (follow-up) same for "remove" action button on bundle item list Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 153233 [details] [review] Bug 31082: Make the string translatable Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 153234 [details] [review] Bug 31082: (QA follow-up) Fix translation - we are in a .tt not in a .js file Just changing from two to one underscore. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Thanks for all the hard work! Pushed to 23.05.x for the next release
Nice work everyone! Pushed to oldstable for 22.11.x