Bug 31085

Summary:	The return claims table no longer reloads on resolution
Product:	Koha	Reporter:	Martin Renvoize (ashimema) <martin.renvoize>
Component:	Circulation	Assignee:	Martin Renvoize (ashimema) <martin.renvoize>
Status:	CLOSED FIXED	QA Contact:	Kyle M Hall (khall) <kyle>
Severity:	normal
Priority:	P5 - low	CC:	arthur.suzuki, gmcharlt, kyle.m.hall, lucas, victor
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	22.11.00, 22.05.04, 21.11.11
Circulation function:
Bug Depends on:	29519
Bug Blocks:	28854
Attachments:	Bug 31085: Reload return claims table on resolve Bug 31085: Reload return claims table on resolve

Description Martin Renvoize (ashimema) 2022-07-01 14:34:00 UTC

In bug 29519 we split out the returns claim resolution modal and form so they could be re-used on the check-in screen.

However, I missed something.  When resolving a claim from the details or checkout screens the claims table should be refreshed.

Currently, we are calling an undefined function and this leads to noise in the console and the table not refreshing as it should.

Comment 1 Martin Renvoize (ashimema) 2022-07-01 14:37:17 UTC

Created attachment 136976 [details] [review]
Bug 31085: Reload return claims table on resolve

This is another fix for a bug in return claims. We now test for the
initialised datatable and call an ajax reload directly on it if we find
one instead of calling a undefined function (the function is out of
scope here).

NOTE: Taken as a whole commit follow-up on bug 28854 where the issue was
initially identified

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Comment 2 Kyle M Hall (khall) 2022-07-01 15:18:59 UTC

Created attachment 137024 [details] [review]
Bug 31085: Reload return claims table on resolve

This is another fix for a bug in return claims. We now test for the
initialised datatable and call an ajax reload directly on it if we find
one instead of calling a undefined function (the function is out of
scope here).

NOTE: Taken as a whole commit follow-up on bug 28854 where the issue was
initially identified

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Comment 3 Tomás Cohen Arazi (tcohen) 2022-07-01 19:43:49 UTC

Pushed to master for 22.11.

Nice work everyone, thanks!

Comment 4 Lucas Gass (lukeg) 2022-08-09 21:19:19 UTC

Backported to 22.05.x for 22.05.04

Comment 5 Arthur Suzuki 2022-08-12 07:07:55 UTC

applied to 21.11.x for 21.11.x

Comment 6 Victor Grousset/tuxayo 2022-08-17 19:25:01 UTC

Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document, marking resolved.