| Summary: | Minor UI problem in recalls history in OPAC | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Caroline Cyr La Rose <caroline.cyr-la-rose> |
| Component: | OPAC | Assignee: | Lucas Gass (lukeg) <lucas> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | arthur.suzuki, lucas, martin.renvoize |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
22.11.00, 22.05.05
|
|
| Circulation function: | |||
| Attachments: |
Recalls history page wth language switch in wrong place
Holds history page for comparison Bug 31146: Fix unclosed table element Bug 31146: Fix unclosed table element Bug 31146: Fix unclosed table element |
||
|
Description
Caroline Cyr La Rose
2022-07-12 19:49:34 UTC
Created attachment 137658 [details]
Recalls history page wth language switch in wrong place
This is a screenshot of the recalls history page in the patron's online account. Note that the language switch is right under the table
Created attachment 137659 [details]
Holds history page for comparison
This is a screenshot of the holds history page in the patron's online account. Note that the language switch is at the bottom left.
There is a small mistake in the markup, an unclosed table element. Created attachment 137732 [details] [review] Bug 31146: Fix unclosed table element To test: 1) Install another language and enable it in the OPACLanguages system preference 2) Also make sure opaclanguagesdisplay is set to Allow 3) Make sure OpacLangSelectorMode is set to display the switch in the footer (either top and bottom or footer only) 4) Turn on recalls 4.1) In Administration > Global system preferences, enable UseRecalls 4.2) Add recalls permissions in your circulation rules 5) In the OPAC, log in as a patron 6) Find a record with checked out items and place a recall 7) Go to your account --> Note that the language switch is at the bottom left of the screen 8) Click on any tab in the patron's account --> Note that the language switch is at the bottom left of the screen 9) Click on 'Your recalls history' --> Note that the language switch is right under the recalls history table 10) Apply patch 11) The changelanguage div should now be properly placed at the bottom of the page. https://bugs.koha-community.org/show_bug.cgi?id=31153 Created attachment 137735 [details] [review] Bug 31146: Fix unclosed table element To test: 1) Install another language and enable it in the OPACLanguages system preference 2) Also make sure opaclanguagesdisplay is set to Allow 3) Make sure OpacLangSelectorMode is set to display the switch in the footer (either top and bottom or footer only) 4) Turn on recalls 4.1) In Administration > Global system preferences, enable UseRecalls 4.2) Add recalls permissions in your circulation rules 5) In the OPAC, log in as a patron 6) Find a record with checked out items and place a recall 7) Go to your account --> Note that the language switch is at the bottom left of the screen 8) Click on any tab in the patron's account --> Note that the language switch is at the bottom left of the screen 9) Click on 'Your recalls history' --> Note that the language switch is right under the recalls history table 10) Apply patch 11) The changelanguage div should now be properly placed at the bottom of the page. https://bugs.koha-community.org/show_bug.cgi?id=31153 Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Thanks for this Lucas! It works perfectly Created attachment 137766 [details] [review] Bug 31146: Fix unclosed table element To test: 1) Install another language and enable it in the OPACLanguages system preference 2) Also make sure opaclanguagesdisplay is set to Allow 3) Make sure OpacLangSelectorMode is set to display the switch in the footer (either top and bottom or footer only) 4) Turn on recalls 4.1) In Administration > Global system preferences, enable UseRecalls 4.2) Add recalls permissions in your circulation rules 5) In the OPAC, log in as a patron 6) Find a record with checked out items and place a recall 7) Go to your account --> Note that the language switch is at the bottom left of the screen 8) Click on any tab in the patron's account --> Note that the language switch is at the bottom left of the screen 9) Click on 'Your recalls history' --> Note that the language switch is right under the recalls history table 10) Apply patch 11) The changelanguage div should now be properly placed at the bottom of the page. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Nice quick fixing there.. Passing QA Pushed to master for 22.11. Nice work everyone, thanks! Bakported to 22.05.x for 22.05.05 Recalls feature not present in 21.11.x. this bug is not relevant to backport in 21.11.x. |