Bug 31146 - Minor UI problem in recalls history in OPAC
Summary: Minor UI problem in recalls history in OPAC
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Lucas Gass
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-07-12 19:49 UTC by Caroline Cyr La Rose
Modified: 2023-06-08 22:26 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00, 22.05.05


Attachments
Recalls history page wth language switch in wrong place (106.98 KB, image/png)
2022-07-12 19:50 UTC, Caroline Cyr La Rose
Details
Holds history page for comparison (117.73 KB, image/png)
2022-07-12 19:51 UTC, Caroline Cyr La Rose
Details
Bug 31146: Fix unclosed table element (1.98 KB, patch)
2022-07-14 15:34 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 31146: Fix unclosed table element (2.05 KB, patch)
2022-07-14 17:09 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 31146: Fix unclosed table element (2.06 KB, patch)
2022-07-15 14:41 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2022-07-12 19:49:34 UTC
This is very minor, but I figured it might make an easy fix for someone...

When recalls are turned on, the patron has access to their recalls history in their online account. If the OPAC is multilingual, the language switcher is right under the recalls history table, rather than being at the bottom of the page where it normally is.

To test:
1) Install another language and enable it in the OPACLanguages system preference
2) Also make sure opaclanguagesdisplay is set to Allow
3) Make sure OpacLangSelectorMode is set to display the switch in the footer (either top and bottom or footer only)
4) Turn on recalls
   4.1) In Administration > Global system preferences, enable UseRecalls
   4.2) Add recalls permissions in your circulation rules
5) In the OPAC, log in as a patron
6) Find a record with checked out items and place a recall
7) Go to your account
--> Note that the language switch is at the bottom left of the screen
8) Click on any tab in the patron's account
--> Note that the language switch is at the bottom left of the screen
9) Click on 'Your recalls history'
--> Note that the language switch is right under the recalls history table
Comment 1 Caroline Cyr La Rose 2022-07-12 19:50:39 UTC
Created attachment 137658 [details]
Recalls history page wth language switch in wrong place

This is a screenshot of the recalls history page in the patron's online account. Note that the language switch is right under the table
Comment 2 Caroline Cyr La Rose 2022-07-12 19:51:31 UTC
Created attachment 137659 [details]
Holds history page for comparison

This is a screenshot of the holds history page in the patron's online account. Note that the language switch is at the bottom left.
Comment 3 Lucas Gass 2022-07-14 15:29:29 UTC
There is a small mistake in the markup, an unclosed table element.
Comment 4 Lucas Gass 2022-07-14 15:34:00 UTC
Created attachment 137732 [details] [review]
Bug 31146: Fix unclosed table element

To test:
1) Install another language and enable it in the OPACLanguages system preference
2) Also make sure opaclanguagesdisplay is set to Allow
3) Make sure OpacLangSelectorMode is set to display the switch in the footer (either top and bottom or footer only)
4) Turn on recalls
   4.1) In Administration > Global system preferences, enable UseRecalls
   4.2) Add recalls permissions in your circulation rules
5) In the OPAC, log in as a patron
6) Find a record with checked out items and place a recall
7) Go to your account
--> Note that the language switch is at the bottom left of the screen
8) Click on any tab in the patron's account
--> Note that the language switch is at the bottom left of the screen
9) Click on 'Your recalls history'
--> Note that the language switch is right under the recalls history table
10) Apply patch
11) The changelanguage div should now be properly placed at the bottom of the page.

https://bugs.koha-community.org/show_bug.cgi?id=31153
Comment 5 Caroline Cyr La Rose 2022-07-14 17:09:00 UTC
Created attachment 137735 [details] [review]
Bug 31146: Fix unclosed table element

To test:
1) Install another language and enable it in the OPACLanguages system preference
2) Also make sure opaclanguagesdisplay is set to Allow
3) Make sure OpacLangSelectorMode is set to display the switch in the footer (either top and bottom or footer only)
4) Turn on recalls
   4.1) In Administration > Global system preferences, enable UseRecalls
   4.2) Add recalls permissions in your circulation rules
5) In the OPAC, log in as a patron
6) Find a record with checked out items and place a recall
7) Go to your account
--> Note that the language switch is at the bottom left of the screen
8) Click on any tab in the patron's account
--> Note that the language switch is at the bottom left of the screen
9) Click on 'Your recalls history'
--> Note that the language switch is right under the recalls history table
10) Apply patch
11) The changelanguage div should now be properly placed at the bottom of the page.

https://bugs.koha-community.org/show_bug.cgi?id=31153
Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Comment 6 Caroline Cyr La Rose 2022-07-14 17:09:31 UTC
Thanks for this Lucas! It works perfectly
Comment 7 Martin Renvoize 2022-07-15 14:41:35 UTC
Created attachment 137766 [details] [review]
Bug 31146: Fix unclosed table element

To test:
1) Install another language and enable it in the OPACLanguages system preference
2) Also make sure opaclanguagesdisplay is set to Allow
3) Make sure OpacLangSelectorMode is set to display the switch in the footer (either top and bottom or footer only)
4) Turn on recalls
   4.1) In Administration > Global system preferences, enable UseRecalls
   4.2) Add recalls permissions in your circulation rules
5) In the OPAC, log in as a patron
6) Find a record with checked out items and place a recall
7) Go to your account
--> Note that the language switch is at the bottom left of the screen
8) Click on any tab in the patron's account
--> Note that the language switch is at the bottom left of the screen
9) Click on 'Your recalls history'
--> Note that the language switch is right under the recalls history table
10) Apply patch
11) The changelanguage div should now be properly placed at the bottom of the page.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 8 Martin Renvoize 2022-07-15 14:42:06 UTC
Nice quick fixing there..

Passing QA
Comment 9 Tomás Cohen Arazi 2022-07-18 13:31:56 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 10 Lucas Gass 2022-08-23 16:18:03 UTC
Bakported to 22.05.x for 22.05.05
Comment 11 Arthur Suzuki 2022-08-26 08:21:24 UTC
Recalls feature not present in 21.11.x. this bug is not relevant to backport in 21.11.x.