Summary: | Search result numbering in OPAC got suppressed | ||
---|---|---|---|
Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
Component: | OPAC | Assignee: | Marcel de Rooy <m.de.rooy> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | arthur.suzuki, fridolin.somers, lucas, tomascohen, victor |
Version: | Main | Keywords: | regression |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.11.00, 22.05.05, 21.11.12
|
|
Circulation function: | |||
Attachments: |
Bug 31186: Fix the hidingrules test for result numbering
Bug 31186: Fix the hidingrules test for result numbering |
Description
Marcel de Rooy
2022-07-19 11:27:43 UTC
Created attachment 137861 [details] [review] Bug 31186: Fix the hidingrules test for result numbering We should not test the $hidingrules variable but the number of keys it contains. Test plan: Clear OpacHiddenItems. Check with and without this patch search result numbering on the OPAC. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Super trivial Created attachment 137936 [details] [review] Bug 31186: Fix the hidingrules test for result numbering We should not test the $hidingrules variable but the number of keys it contains. Test plan: Clear OpacHiddenItems. Check with and without this patch search result numbering on the OPAC. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 22.11. Nice work everyone, thanks! *** Bug 31182 has been marked as a duplicate of this bug. *** Backported to 22.05.x for 22.05.05 thx pushed to 21.11.x for 21.11.12 Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. |