| Summary: | Checking in an unkown barcode causes error | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Circulation | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | gmcharlt, kyle.m.hall, lucas, martin.renvoize, sally.healey |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
22.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | 28854 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 31192: Check for item before calling is_bundle
Bug 31192: Check for item before calling is_bundle Bug 31192: Check for item before calling is_bundle |
||
|
Description
Nick Clemens (kidclamp)
2022-07-19 19:40:01 UTC
Created attachment 137896 [details] [review] Bug 31192: Check for item before calling is_bundle The code in here is weird.. we really aught to check for the item before anything else and throw an error to screen if we don't find one... but my patch takes the simple option, and the one taken elsewhere in the script.. to just check for item being defined before calling a method upon it. Created attachment 137903 [details] [review] Bug 31192: Check for item before calling is_bundle The code in here is weird.. we really aught to check for the item before anything else and throw an error to screen if we don't find one... but my patch takes the simple option, and the one taken elsewhere in the script.. to just check for item being defined before calling a method upon it. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> The patch fixes the reported problem, signing off. Thanks for the patch. Created attachment 137926 [details] [review] Bug 31192: Check for item before calling is_bundle The code in here is weird.. we really aught to check for the item before anything else and throw an error to screen if we don't find one... but my patch takes the simple option, and the one taken elsewhere in the script.. to just check for item being defined before calling a method upon it. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 22.11. Nice work everyone, thanks! Missing dependencies for 22.05.x, no backport |