Bug 31229

Summary: Column visibility broken on patron search view
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Staff interfaceAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: normal    
Priority: P5 - low CC: gmcharlt, sally.healey
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Bug Depends on: 30063    
Bug Blocks:    
Attachments: Bug 31229: (bug 30063 follow-up) fix column visibility
Bug 31229: (bug 30063 follow-up) fix column visibility
Bug 31229: (bug 30063 follow-up) fix column visibility

Description Jonathan Druart 2022-07-25 06:53:49 UTC

    
Comment 1 Jonathan Druart 2022-07-25 06:56:25 UTC
Created attachment 138071 [details] [review]
Bug 31229: (bug 30063 follow-up) fix column visibility

Fix bad conflict resolution with bug 29648.

Test plan:
Confirm that the "Columns" button is displayed on the patron result view
and that it works as expected.
Comment 2 ByWater Sandboxes 2022-07-25 08:24:18 UTC
Created attachment 138074 [details] [review]
Bug 31229: (bug 30063 follow-up) fix column visibility

Fix bad conflict resolution with bug 29648.

Test plan:
Confirm that the "Columns" button is displayed on the patron result view
and that it works as expected.

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Comment 3 Sally 2022-07-25 08:24:47 UTC
Works as described, signing off.  Thanks for the patch!
Comment 4 Katrin Fischer 2022-07-25 21:40:20 UTC
Created attachment 138105 [details] [review]
Bug 31229: (bug 30063 follow-up) fix column visibility

Fix bad conflict resolution with bug 29648.

Test plan:
Confirm that the "Columns" button is displayed on the patron result view
and that it works as expected.

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Tomás Cohen Arazi 2022-07-26 12:34:43 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!