Bug 29530 discussed, that the NumSavedReports would be better placed as an option in the table configuration settings. Using this as a pattern could also then help add this option to more tables.
Created attachment 128592 [details] [review] Bug 29648: Improve existing code We already have 2 tables that are configurable, on acqui/basket and reports/orders_by_budget. This patch is modifying a bit the existing code to transfer the responsability/logic to the KohaTable constructor instead of the template that is creating the object.
Created attachment 128593 [details] [review] Bug 29648: Move NumSavedReports to the table settings The syspref NumSavedReports can be moved to the table settings config Test plan: 1. Set the syspref to a given value 2. updatedatabase # execute the atomic update 3. Go to the table settings page and confirm that the syspref's value has been retrieved 4. Select a specific colonne for the default sort 5. Go to the report list view and confirm that the "Show X entries" has the correct selected value and that the table is sorted as you expect.
Created attachment 128594 [details] [review] Bug 29648: Add item - broken FIXME Why don't we have the columns visibility button? It looks like there is something broken here, why don't we have the show/hide columns buttons? The code expects it to be displayed.
Created attachment 128595 [details] [review] Bug 29648: Duplicate orders view - no change No change expected here, only removing commented-out code.
Created attachment 128596 [details] [review] Bug 29648: Order search view - normal "normal" means that we are expecting the table to have the 2 options implemented and working. You can select "Default display length" and "Default sort order" in the "table settings" administration view, then go the the view and confirm that the table has the configured values pre-selected.
Created attachment 128597 [details] [review] Bug 29648: Late orders view - normal
Created attachment 128598 [details] [review] Bug 29648: Authorised values view No change is expected on this view as the table is not part of the table settings.
Created attachment 128599 [details] [review] Bug 29648: Libraries administration view - normale
Created attachment 128600 [details] [review] Bug 29648: Patron categories administration view - normal
Created attachment 128601 [details] [review] Bug 29648: Cities administration view - REST API Here we need to deal with the other DT config (in datatables.js, not columns_settings.inc). Test plan: Same as "normal"
Created attachment 128602 [details] [review] Bug 29648: Item types administration view Set noItemTypeImages and OpacNoItemTypeImages to "No" and confirm that the first column (the image) is not displayed. Otherwise test as "normal"
Created attachment 128603 [details] [review] Bug 29648: Allow tables_settings.default_display_length to be NULL We actually want this value to be NULL. If set to NULL and default_display_length is not in the yml, then the option will not be displayed.
Created attachment 128604 [details] [review] Bug 29648: DBIC Schema changes
Created attachment 128605 [details] [review] Bug 29648: Catalogue detail - no default_display_length On the acquisition table the sort option is not available as we don't offer the ability to selection asc/desc and default to asc. We cannot offer default_display_length for those tables.
Created attachment 128606 [details] [review] Bug 29648: Checkout history - normal no sort
Created attachment 128607 [details] [review] Bug 29648: Cataloguing Z3950 search - no pagination Pagination is done server-side
Created attachment 128608 [details] [review] Bug 29648: Overdue list - normal 'stateSave' so need to test on the first try or delete the relevant local storage entry
Created attachment 128609 [details] [review] Bug 29648: Holds to pull - normal
Created attachment 128610 [details] [review] Bug 29648: Holds ratios - normal but no sort
Created attachment 128611 [details] [review] Bug 29648: Returns - no change No change expected here, there is no sort and no paginate possible.
Created attachment 128612 [details] [review] Bug 29648: Holds queue - only sort
Created attachment 128613 [details] [review] Bug 29648: Course reserve detail - normal
Created attachment 128614 [details] [review] Bug 29648: Course reserve list - normal
Created attachment 128615 [details] [review] Bug 29648: ILL - no change No change expected here for ILL
Created attachment 128616 [details] [review] Bug 29648: Patron accounting page - no sort because of desc
Created attachment 128617 [details] [review] Bug 29648: Holds history - no sort because of desc
Created attachment 128618 [details] [review] Bug 29648: Patron page (PatronsPerPage) - no change PatronsPerPage should be done on a separate bug report, not trivial
Created attachment 128619 [details] [review] Bug 29648: Payments - normal
Created attachment 128620 [details] [review] Bug 29648: Checkout history - no sort
Created attachment 128621 [details] [review] Bug 29648: patron list table - normal
Created attachment 128622 [details] [review] Bug 29648: Item lost report - no change hum, there is no sort on this table, so it's displayed like it's coming from the controller, but perl code does not sort either. This could be improved and we could make it configurable easily
Created attachment 128623 [details] [review] Bug 29648: Subscription detail - no change
Created attachment 128624 [details] [review] Bug 29648: Notice template - only sort
Created attachment 128625 [details] [review] Bug 29648: Upload tool - no sort
Created attachment 128626 [details] [review] Bug 29648: Log viewer - no sort
Warning from the QA tool: FAIL C4/Utils/DataTables/TablesSettings.pm FAIL pod *** WARNING: =head3 without preceding higher level in file C4/Utils/DataTables/TablesSettings.pm *** WARNING: =head3 without preceding higher level in file C4/Utils/DataTables/TablesSettings.pm
This change results in a JS error on the page, 'Uncaught TypeError: can't access property "columns", table_settings is undefined' --- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/duplicate_orders.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/duplicate_orders.tt @@ -328,10 +328,9 @@ Acquisitions › Koha var MSG_NO_FUND_SELECTED = _("No fund selected."); $(document).ready(function() { $('span.hint').hide(); - var columns_settings;// = [% TablesSettings.GetColumns( 'acqui', 'histsearch', 'histsearcht', 'json' ) | $raw %]; KohaTable("table_orders", { "bPaginate": false - }, columns_settings ); + });
(In reply to Owen Leonard from comment #37) > This change results in a JS error on the page, 'Uncaught TypeError: can't > access property "columns", table_settings is undefined' Fixed in a later patch, or a false alarm? I'm going through them in smaller chunks.
More notes: - On the bibliographic detail page, the default sort column doesn't work correctly. Why are there so many columns to configure when they don't exist in the table? - On the overdues page the default sort order and default display length aren't applied. - Holds to pull: Column configuration doesn't seem to work. - Holds history: 'Uncaught TypeError: can't access property "filter", table_settings.columns is undefined' - Notice template: Column configuration doesn't work. Columns selected to be hidden are not hidden.
Created attachment 129084 [details] [review] Bug 29648: Holds history - no sort because of desc
Created attachment 129085 [details] [review] Bug 29648: Notice template - only sort
(In reply to Owen Leonard from comment #39) > More notes: > > - On the bibliographic detail page, the default sort column doesn't work > correctly. Why are there so many columns to configure when they don't exist > in the table? It seems to work for me, I selected "holdings_holdinbranch" and the table is sorted by "Home library". The table settings is listing all the columns that can be displayed, but only the non-empty columns are displayed. For instance if none of your items have $u, then the "URL" column won't be displayed. > - On the overdues page the default sort order and default display length > aren't applied. This table has the stateSave flag on. You need to remove the local storage item before trying it. > - Holds to pull: Column configuration doesn't seem to work. I have selected 50 and "patron" and it's working for me. Can you detail? > - Holds history: 'Uncaught TypeError: can't access property "filter", > table_settings.columns is undefined' Oops, fixed! > - Notice template: Column configuration doesn't work. Columns selected to be > hidden are not hidden. Fixed!
Created attachment 129089 [details] [review] Bug 29648: Fix occurrences of GetColumns We could add the configuration to these tables as well, but let go first but the others (read: feeling lazy right now).
Created attachment 129352 [details] [review] Bug 29648: Remove default sort order for detail On the detail view the number of columns changed, we cannot use the default sort order here. It certainly can be done on a different way but I prefer to postpone it for now and see later.
I ran into a few other issues: * Reservoir search (addbooks.pl) is missing the columns control button * waitingreserves.pl has a JS error: "holdst_columns_settings is not defined" * marc_modification_templates columns not hiding according the the configuration, and the columns control button is missing
Created attachment 129685 [details] [review] Bug 29648: Upload tool - no sort
Created attachment 129686 [details] [review] Bug 29648: Fix occurrences of GetColumns We could add the configuration to these tables as well, but let go first but the others (read: feeling lazy right now).
(In reply to Owen Leonard from comment #45) > I ran into a few other issues: > > * Reservoir search (addbooks.pl) is missing the columns control button > * waitingreserves.pl has a JS error: "holdst_columns_settings is not defined" > * marc_modification_templates columns not hiding according the the > configuration, and the columns control button is missing Thanks, Owen. This is now fixed.
Created attachment 129770 [details] [review] Bug 29648: Improve existing code We already have 2 tables that are configurable, on acqui/basket and reports/orders_by_budget. This patch is modifying a bit the existing code to transfer the responsability/logic to the KohaTable constructor instead of the template that is creating the object. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 129771 [details] [review] Bug 29648: Move NumSavedReports to the table settings The syspref NumSavedReports can be moved to the table settings config Test plan: 1. Set the syspref to a given value 2. updatedatabase # execute the atomic update 3. Go to the table settings page and confirm that the syspref's value has been retrieved 4. Select a specific colonne for the default sort 5. Go to the report list view and confirm that the "Show X entries" has the correct selected value and that the table is sorted as you expect. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 129772 [details] [review] Bug 29648: Add item - broken FIXME Why don't we have the columns visibility button? It looks like there is something broken here, why don't we have the show/hide columns buttons? The code expects it to be displayed. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 129773 [details] [review] Bug 29648: Duplicate orders view - no change No change expected here, only removing commented-out code. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 129774 [details] [review] Bug 29648: Order search view - normal "normal" means that we are expecting the table to have the 2 options implemented and working. You can select "Default display length" and "Default sort order" in the "table settings" administration view, then go the the view and confirm that the table has the configured values pre-selected. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 129775 [details] [review] Bug 29648: Late orders view - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 129776 [details] [review] Bug 29648: Authorised values view No change is expected on this view as the table is not part of the table settings. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 129777 [details] [review] Bug 29648: Libraries administration view - normale Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 129778 [details] [review] Bug 29648: Patron categories administration view - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 129779 [details] [review] Bug 29648: Cities administration view - REST API Here we need to deal with the other DT config (in datatables.js, not columns_settings.inc). Test plan: Same as "normal" Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 129780 [details] [review] Bug 29648: Item types administration view Set noItemTypeImages and OpacNoItemTypeImages to "No" and confirm that the first column (the image) is not displayed. Otherwise test as "normal" Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 129781 [details] [review] Bug 29648: Allow tables_settings.default_display_length to be NULL We actually want this value to be NULL. If set to NULL and default_display_length is not in the yml, then the option will not be displayed. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 129782 [details] [review] Bug 29648: DBIC Schema changes Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 129783 [details] [review] Bug 29648: Catalogue detail - no default_display_length On the acquisition table the sort option is not available as we don't offer the ability to selection asc/desc and default to asc. We cannot offer default_display_length for those tables. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 129784 [details] [review] Bug 29648: Checkout history - normal no sort Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 129785 [details] [review] Bug 29648: Cataloguing Z3950 search - no pagination Pagination is done server-side Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 129786 [details] [review] Bug 29648: Overdue list - normal 'stateSave' so need to test on the first try or delete the relevant local storage entry Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 129787 [details] [review] Bug 29648: Holds to pull - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 129788 [details] [review] Bug 29648: Holds ratios - normal but no sort Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 129789 [details] [review] Bug 29648: Returns - no change No change expected here, there is no sort and no paginate possible. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 129790 [details] [review] Bug 29648: Holds queue - only sort Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 129791 [details] [review] Bug 29648: Course reserve detail - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 129792 [details] [review] Bug 29648: Course reserve list - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 129793 [details] [review] Bug 29648: ILL - no change No change expected here for ILL Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 129794 [details] [review] Bug 29648: Patron accounting page - no sort because of desc Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 129795 [details] [review] Bug 29648: Patron page (PatronsPerPage) - no change PatronsPerPage should be done on a separate bug report, not trivial Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 129796 [details] [review] Bug 29648: Payments - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 129797 [details] [review] Bug 29648: Checkout history - no sort Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 129798 [details] [review] Bug 29648: patron list table - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 129799 [details] [review] Bug 29648: Item lost report - no change hum, there is no sort on this table, so it's displayed like it's coming from the controller, but perl code does not sort either. This could be improved and we could make it configurable easily Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 129800 [details] [review] Bug 29648: Subscription detail - no change Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 129801 [details] [review] Bug 29648: Log viewer - no sort Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 129802 [details] [review] Bug 29648: Holds history - no sort because of desc Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 129803 [details] [review] Bug 29648: Notice template - only sort Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 129804 [details] [review] Bug 29648: Remove default sort order for detail On the detail view the number of columns changed, we cannot use the default sort order here. It certainly can be done on a different way but I prefer to postpone it for now and see later. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 129805 [details] [review] Bug 29648: Upload tool - no sort Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 129806 [details] [review] Bug 29648: Fix occurrences of GetColumns We could add the configuration to these tables as well, but let go first but the others (read: feeling lazy right now). Signed-off-by: Owen Leonard <oleonard@myacpl.org>
I'm sorry, can you please rebase the last patch?
Created attachment 131703 [details] [review] Bug 29648: Fix occurrences of GetColumns We could add the configuration to these tables as well, but let go first but the others (read: feeling lazy right now). Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 131875 [details] [review] Bug 29648: Returns - no change No change expected here, there is no sort and no paginate possible. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 131876 [details] [review] Bug 29648: Fix occurrences of GetColumns We could add the configuration to these tables as well, but let go first but the others (read: feeling lazy right now). Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 133001 [details] [review] Bug 29648: Item types administration view Set noItemTypeImages and OpacNoItemTypeImages to "No" and confirm that the first column (the image) is not displayed. Otherwise test as "normal" Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 133002 [details] [review] Bug 29648: Allow tables_settings.default_display_length to be NULL We actually want this value to be NULL. If set to NULL and default_display_length is not in the yml, then the option will not be displayed. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 133003 [details] [review] Bug 29648: DBIC Schema changes Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 133004 [details] [review] Bug 29648: Catalogue detail - no default_display_length On the acquisition table the sort option is not available as we don't offer the ability to selection asc/desc and default to asc. We cannot offer default_display_length for those tables. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 133005 [details] [review] Bug 29648: Checkout history - normal no sort Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 133006 [details] [review] Bug 29648: Cataloguing Z3950 search - no pagination Pagination is done server-side Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 133007 [details] [review] Bug 29648: Overdue list - normal 'stateSave' so need to test on the first try or delete the relevant local storage entry Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 133008 [details] [review] Bug 29648: Holds to pull - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 133009 [details] [review] Bug 29648: Holds ratios - normal but no sort Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 133010 [details] [review] Bug 29648: Holds queue - only sort Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 133011 [details] [review] Bug 29648: Course reserve detail - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 133012 [details] [review] Bug 29648: Course reserve list - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 133013 [details] [review] Bug 29648: ILL - no change No change expected here for ILL Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 133014 [details] [review] Bug 29648: Patron accounting page - no sort because of desc Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 133015 [details] [review] Bug 29648: Patron page (PatronsPerPage) - no change PatronsPerPage should be done on a separate bug report, not trivial Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 133016 [details] [review] Bug 29648: Payments - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 133017 [details] [review] Bug 29648: Checkout history - no sort Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 133018 [details] [review] Bug 29648: patron list table - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 133019 [details] [review] Bug 29648: Item lost report - no change hum, there is no sort on this table, so it's displayed like it's coming from the controller, but perl code does not sort either. This could be improved and we could make it configurable easily Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 133020 [details] [review] Bug 29648: Subscription detail - no change Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 133021 [details] [review] Bug 29648: Log viewer - no sort Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 133022 [details] [review] Bug 29648: Holds history - no sort because of desc Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 133023 [details] [review] Bug 29648: Notice template - only sort Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 133024 [details] [review] Bug 29648: Remove default sort order for detail On the detail view the number of columns changed, we cannot use the default sort order here. It certainly can be done on a different way but I prefer to postpone it for now and see later. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 133025 [details] [review] Bug 29648: Upload tool - no sort Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 133026 [details] [review] Bug 29648: Returns - no change No change expected here, there is no sort and no paginate possible. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 133027 [details] [review] Bug 29648: Fix occurrences of GetColumns We could add the configuration to these tables as well, but let go first but the others (read: feeling lazy right now). Signed-off-by: Owen Leonard <oleonard@myacpl.org>
QA please? This is a nightmare to rebase!
(In reply to Jonathan Druart from comment #117) > QA please? This is a nightmare to rebase! Sorry to be late :( Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 29648: Improve existing code Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc M koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt M koha-tmpl/intranet-tmpl/prog/en/modules/reports/orders_by_budget.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/reports/orders_by_budget.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc error: Failed to merge in the changes. Patch failed at 0001 Bug 29648: Improve existing code Could you please rebase? I'll try to get back to this ASAP after.
Created attachment 134018 [details] [review] Bug 29648: Improve existing code We already have 2 tables that are configurable, on acqui/basket and reports/orders_by_budget. This patch is modifying a bit the existing code to transfer the responsability/logic to the KohaTable constructor instead of the template that is creating the object. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 134019 [details] [review] Bug 29648: Move NumSavedReports to the table settings The syspref NumSavedReports can be moved to the table settings config Test plan: 1. Set the syspref to a given value 2. updatedatabase # execute the atomic update 3. Go to the table settings page and confirm that the syspref's value has been retrieved 4. Select a specific colonne for the default sort 5. Go to the report list view and confirm that the "Show X entries" has the correct selected value and that the table is sorted as you expect. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 134020 [details] [review] Bug 29648: Add item - broken FIXME Why don't we have the columns visibility button? It looks like there is something broken here, why don't we have the show/hide columns buttons? The code expects it to be displayed. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 134021 [details] [review] Bug 29648: Duplicate orders view - no change No change expected here, only removing commented-out code. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 134022 [details] [review] Bug 29648: Order search view - normal "normal" means that we are expecting the table to have the 2 options implemented and working. You can select "Default display length" and "Default sort order" in the "table settings" administration view, then go the the view and confirm that the table has the configured values pre-selected. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 134023 [details] [review] Bug 29648: Late orders view - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 134024 [details] [review] Bug 29648: Authorised values view No change is expected on this view as the table is not part of the table settings. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 134025 [details] [review] Bug 29648: Libraries administration view - normale Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 134026 [details] [review] Bug 29648: Patron categories administration view - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 134027 [details] [review] Bug 29648: Cities administration view - REST API Here we need to deal with the other DT config (in datatables.js, not columns_settings.inc). Test plan: Same as "normal" Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 134028 [details] [review] Bug 29648: Item types administration view Set noItemTypeImages and OpacNoItemTypeImages to "No" and confirm that the first column (the image) is not displayed. Otherwise test as "normal" Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 134029 [details] [review] Bug 29648: Allow tables_settings.default_display_length to be NULL We actually want this value to be NULL. If set to NULL and default_display_length is not in the yml, then the option will not be displayed. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 134030 [details] [review] Bug 29648: DBIC Schema changes Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 134031 [details] [review] Bug 29648: Catalogue detail - no default_display_length On the acquisition table the sort option is not available as we don't offer the ability to selection asc/desc and default to asc. We cannot offer default_display_length for those tables. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 134032 [details] [review] Bug 29648: Checkout history - normal no sort Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 134033 [details] [review] Bug 29648: Cataloguing Z3950 search - no pagination Pagination is done server-side Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 134034 [details] [review] Bug 29648: Overdue list - normal 'stateSave' so need to test on the first try or delete the relevant local storage entry Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 134035 [details] [review] Bug 29648: Holds to pull - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 134036 [details] [review] Bug 29648: Holds ratios - normal but no sort Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 134037 [details] [review] Bug 29648: Holds queue - only sort Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 134038 [details] [review] Bug 29648: Course reserve detail - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 134039 [details] [review] Bug 29648: Course reserve list - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 134040 [details] [review] Bug 29648: ILL - no change No change expected here for ILL Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 134041 [details] [review] Bug 29648: Patron accounting page - no sort because of desc Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 134042 [details] [review] Bug 29648: Patron page (PatronsPerPage) - no change PatronsPerPage should be done on a separate bug report, not trivial Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 134043 [details] [review] Bug 29648: Payments - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 134044 [details] [review] Bug 29648: Checkout history - no sort Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 134045 [details] [review] Bug 29648: patron list table - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 134046 [details] [review] Bug 29648: Item lost report - no change hum, there is no sort on this table, so it's displayed like it's coming from the controller, but perl code does not sort either. This could be improved and we could make it configurable easily Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 134047 [details] [review] Bug 29648: Subscription detail - no change Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 134048 [details] [review] Bug 29648: Log viewer - no sort Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 134049 [details] [review] Bug 29648: Holds history - no sort because of desc Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 134050 [details] [review] Bug 29648: Notice template - only sort Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 134051 [details] [review] Bug 29648: Remove default sort order for detail On the detail view the number of columns changed, we cannot use the default sort order here. It certainly can be done on a different way but I prefer to postpone it for now and see later. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 134052 [details] [review] Bug 29648: Upload tool - no sort Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 134053 [details] [review] Bug 29648: Returns - no change No change expected here, there is no sort and no paginate possible. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 134054 [details] [review] Bug 29648: Fix occurrences of GetColumns We could add the configuration to these tables as well, but let go first but the others (read: feeling lazy right now). Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 134086 [details] [review] Bug 29648: Improve existing code We already have 2 tables that are configurable, on acqui/basket and reports/orders_by_budget. This patch is modifying a bit the existing code to transfer the responsability/logic to the KohaTable constructor instead of the template that is creating the object. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 134087 [details] [review] Bug 29648: Move NumSavedReports to the table settings The syspref NumSavedReports can be moved to the table settings config Test plan: 1. Set the syspref to a given value 2. updatedatabase # execute the atomic update 3. Go to the table settings page and confirm that the syspref's value has been retrieved 4. Select a specific colonne for the default sort 5. Go to the report list view and confirm that the "Show X entries" has the correct selected value and that the table is sorted as you expect. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 134088 [details] [review] Bug 29648: Add item - broken FIXME Why don't we have the columns visibility button? It looks like there is something broken here, why don't we have the show/hide columns buttons? The code expects it to be displayed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 134089 [details] [review] Bug 29648: Duplicate orders view - no change No change expected here, only removing commented-out code. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 134090 [details] [review] Bug 29648: Order search view - normal "normal" means that we are expecting the table to have the 2 options implemented and working. You can select "Default display length" and "Default sort order" in the "table settings" administration view, then go the the view and confirm that the table has the configured values pre-selected. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 134091 [details] [review] Bug 29648: Late orders view - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 134092 [details] [review] Bug 29648: Authorised values view No change is expected on this view as the table is not part of the table settings. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 134093 [details] [review] Bug 29648: Libraries administration view - normale Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 134094 [details] [review] Bug 29648: Patron categories administration view - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 134095 [details] [review] Bug 29648: Cities administration view - REST API Here we need to deal with the other DT config (in datatables.js, not columns_settings.inc). Test plan: Same as "normal" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 134096 [details] [review] Bug 29648: Item types administration view Set noItemTypeImages and OpacNoItemTypeImages to "No" and confirm that the first column (the image) is not displayed. Otherwise test as "normal" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 134097 [details] [review] Bug 29648: Allow tables_settings.default_display_length to be NULL We actually want this value to be NULL. If set to NULL and default_display_length is not in the yml, then the option will not be displayed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 134098 [details] [review] Bug 29648: DBIC Schema changes Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 134099 [details] [review] Bug 29648: Catalogue detail - no default_display_length On the acquisition table the sort option is not available as we don't offer the ability to selection asc/desc and default to asc. We cannot offer default_display_length for those tables. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 134100 [details] [review] Bug 29648: Checkout history - normal no sort Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 134101 [details] [review] Bug 29648: Cataloguing Z3950 search - no pagination Pagination is done server-side Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 134102 [details] [review] Bug 29648: Overdue list - normal 'stateSave' so need to test on the first try or delete the relevant local storage entry Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 134103 [details] [review] Bug 29648: Holds to pull - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 134104 [details] [review] Bug 29648: Holds ratios - normal but no sort Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 134105 [details] [review] Bug 29648: Holds queue - only sort Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 134106 [details] [review] Bug 29648: Course reserve detail - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 134107 [details] [review] Bug 29648: Course reserve list - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 134108 [details] [review] Bug 29648: ILL - no change No change expected here for ILL Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 134109 [details] [review] Bug 29648: Patron accounting page - no sort because of desc Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 134110 [details] [review] Bug 29648: Patron page (PatronsPerPage) - no change PatronsPerPage should be done on a separate bug report, not trivial Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 134111 [details] [review] Bug 29648: Payments - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 134112 [details] [review] Bug 29648: Checkout history - no sort Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 134113 [details] [review] Bug 29648: patron list table - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 134114 [details] [review] Bug 29648: Item lost report - no change hum, there is no sort on this table, so it's displayed like it's coming from the controller, but perl code does not sort either. This could be improved and we could make it configurable easily Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 134115 [details] [review] Bug 29648: Subscription detail - no change Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 134116 [details] [review] Bug 29648: Log viewer - no sort Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 134117 [details] [review] Bug 29648: Holds history - no sort because of desc Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 134118 [details] [review] Bug 29648: Notice template - only sort Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 134119 [details] [review] Bug 29648: Remove default sort order for detail On the detail view the number of columns changed, we cannot use the default sort order here. It certainly can be done on a different way but I prefer to postpone it for now and see later. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 134120 [details] [review] Bug 29648: Upload tool - no sort Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 134121 [details] [review] Bug 29648: Returns - no change No change expected here, there is no sort and no paginate possible. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 134122 [details] [review] Bug 29648: Fix occurrences of GetColumns We could add the configuration to these tables as well, but let go first but the others (read: feeling lazy right now). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 134123 [details] [review] Bug 29648: (QA follow-up) Minor POD fix This just adds a top level set of POD headings to make the QA script happy Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Looks great to me. Added a small follow-up to keep the QA script happy. Katrin and I overlapped again so I've uploaded my SO and will leave her to set the final PQA :)
I'd say it was teamwork on this one, providing another follow-up. I like to see this getting more flexible and hope we can implement the options for a lot more tables. At some point I'd love to see a primary and secondary sort. For example we get a lot of requests for the OPAC item table to sort by different criteria. One could imagine something like: homebranch, itemtype.
Created attachment 134133 [details] [review] Bug 29648: Improve existing code We already have 2 tables that are configurable, on acqui/basket and reports/orders_by_budget. This patch is modifying a bit the existing code to transfer the responsability/logic to the KohaTable constructor instead of the template that is creating the object. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 134134 [details] [review] Bug 29648: Move NumSavedReports to the table settings The syspref NumSavedReports can be moved to the table settings config Test plan: 1. Set the syspref to a given value 2. updatedatabase # execute the atomic update 3. Go to the table settings page and confirm that the syspref's value has been retrieved 4. Select a specific colonne for the default sort 5. Go to the report list view and confirm that the "Show X entries" has the correct selected value and that the table is sorted as you expect. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 134135 [details] [review] Bug 29648: Add item - broken FIXME Why don't we have the columns visibility button? It looks like there is something broken here, why don't we have the show/hide columns buttons? The code expects it to be displayed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 134136 [details] [review] Bug 29648: Duplicate orders view - no change No change expected here, only removing commented-out code. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 134137 [details] [review] Bug 29648: Order search view - normal "normal" means that we are expecting the table to have the 2 options implemented and working. You can select "Default display length" and "Default sort order" in the "table settings" administration view, then go the the view and confirm that the table has the configured values pre-selected. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 134138 [details] [review] Bug 29648: Late orders view - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 134139 [details] [review] Bug 29648: Authorised values view No change is expected on this view as the table is not part of the table settings. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 134140 [details] [review] Bug 29648: Libraries administration view - normale Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 134141 [details] [review] Bug 29648: Patron categories administration view - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 134142 [details] [review] Bug 29648: Cities administration view - REST API Here we need to deal with the other DT config (in datatables.js, not columns_settings.inc). Test plan: Same as "normal" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 134143 [details] [review] Bug 29648: Item types administration view Set noItemTypeImages and OpacNoItemTypeImages to "No" and confirm that the first column (the image) is not displayed. Otherwise test as "normal" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 134144 [details] [review] Bug 29648: Allow tables_settings.default_display_length to be NULL We actually want this value to be NULL. If set to NULL and default_display_length is not in the yml, then the option will not be displayed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 134145 [details] [review] Bug 29648: DBIC Schema changes Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 134146 [details] [review] Bug 29648: Catalogue detail - no default_display_length On the acquisition table the sort option is not available as we don't offer the ability to selection asc/desc and default to asc. We cannot offer default_display_length for those tables. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 134147 [details] [review] Bug 29648: Checkout history - normal no sort Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 134148 [details] [review] Bug 29648: Cataloguing Z3950 search - no pagination Pagination is done server-side Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 134149 [details] [review] Bug 29648: Overdue list - normal 'stateSave' so need to test on the first try or delete the relevant local storage entry Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 134150 [details] [review] Bug 29648: Holds to pull - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 134151 [details] [review] Bug 29648: Holds ratios - normal but no sort Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 134152 [details] [review] Bug 29648: Holds queue - only sort Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 134153 [details] [review] Bug 29648: Course reserve detail - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 134154 [details] [review] Bug 29648: Course reserve list - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 134155 [details] [review] Bug 29648: ILL - no change No change expected here for ILL Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 134156 [details] [review] Bug 29648: Patron accounting page - no sort because of desc Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 134157 [details] [review] Bug 29648: Patron page (PatronsPerPage) - no change PatronsPerPage should be done on a separate bug report, not trivial Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 134158 [details] [review] Bug 29648: Payments - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 134159 [details] [review] Bug 29648: Checkout history - no sort Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 134160 [details] [review] Bug 29648: patron list table - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 134161 [details] [review] Bug 29648: Item lost report - no change hum, there is no sort on this table, so it's displayed like it's coming from the controller, but perl code does not sort either. This could be improved and we could make it configurable easily Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 134162 [details] [review] Bug 29648: Subscription detail - no change Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 134163 [details] [review] Bug 29648: Log viewer - no sort Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 134164 [details] [review] Bug 29648: Holds history - no sort because of desc Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 134165 [details] [review] Bug 29648: Notice template - only sort Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 134166 [details] [review] Bug 29648: Remove default sort order for detail On the detail view the number of columns changed, we cannot use the default sort order here. It certainly can be done on a different way but I prefer to postpone it for now and see later. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 134167 [details] [review] Bug 29648: Upload tool - no sort Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 134168 [details] [review] Bug 29648: Returns - no change No change expected here, there is no sort and no paginate possible. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 134169 [details] [review] Bug 29648: Fix occurrences of GetColumns We could add the configuration to these tables as well, but let go first but the others (read: feeling lazy right now). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 134170 [details] [review] Bug 29648: (QA follow-up) Minor POD fix This just adds a top level set of POD headings to make the QA script happy Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 134171 [details] [review] Bug 29648: (QA follow-up) Remove NumSavedReports from .pref file Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 134194 [details] [review] Bug 29648: (follow-up) Add missing raw filter
Great enhancement. I push it asap to avoid more rebase.
Ah we should remove "actions" from default sort order. My 2c
(In reply to Fridolin Somers from comment #237) > Ah we should remove "actions" from default sort order. > My 2c And also "selection". Using them does not break the table, ouf ;)
I've added to DBRev a print when preference was enabled : "NumSavedReports value '20' moved to table settings"
Pushed to master for 22.05, thanks to everybody involved [U+1F984]